cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(ngcc): expose logging level on the logger (#35861)

Browse Source 
PR Close #35861
This commit is contained in:
Pete Bacon Darwin
2020-03-05 10:42:28 +00:00
committed by Matias Niemelä
parent 98a9daf4f4
commit bdaab4184d
7 changed files with 33 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/compiler-cli/ngcc/test/helpers/mock_logger.ts
View File

@ -6,10 +6,12 @@
* found in the LICENSE file at https://angular.io/license
*/
import {Logger} from '../../src/logging/logger';
import {LogLevel, Logger} from '../../src/logging/logger';
export class MockLogger implements Logger {
logs: {[P in keyof Logger]: string[][]} = {
constructor(public level = LogLevel.info) {}
logs: {[P in Exclude<keyof Logger, 'level'>]: string[][]} = {
debug: [],
info: [],
warn: [],

10
packages/compiler-cli/ngcc/test/logging/console_logger_spec.ts
View File

@ -5,7 +5,8 @@
* Use of this source code is governed by an MIT-style license that can be
* found in the LICENSE file at https://angular.io/license
*/
import {ConsoleLogger, DEBUG, ERROR, LogLevel, WARN} from '../../src/logging/console_logger';
import {ConsoleLogger, DEBUG, ERROR, WARN} from '../../src/logging/console_logger';
import {LogLevel} from '../../src/logging/logger';
describe('ConsoleLogger', () => {
it('should pass through calls to Console', () => {
@ -47,4 +48,11 @@ describe('ConsoleLogger', () => {
logger.error('error', 'test');
expect(console.error).toHaveBeenCalledWith(ERROR, 'error', 'test');
});
it('should expose the logging level', () => {
expect(new ConsoleLogger(LogLevel.debug).level).toEqual(LogLevel.debug);
expect(new ConsoleLogger(LogLevel.info).level).toEqual(LogLevel.info);
expect(new ConsoleLogger(LogLevel.warn).level).toEqual(LogLevel.warn);
expect(new ConsoleLogger(LogLevel.error).level).toEqual(LogLevel.error);
});
});