refactor(compiler): improve types, misc

modules/@angular/compiler/test/directive_lifecycle_spec.ts

@@ -7,8 +7,8 @@
  */
 
 import {hasLifecycleHook} from '@angular/compiler/src/lifecycle_reflector';
-import {LifecycleHooks} from '@angular/core/src/metadata/lifecycle_hooks';
-import {describe, expect, it} from '@angular/core/testing/testing_internal';
+import {SimpleChanges} from '@angular/core';
+import {LifecycleHooks as Hooks} from '@angular/core/src/metadata/lifecycle_hooks';
 
 export function main() {
   describe('Create Directive', () => {
@@ -16,92 +16,81 @@ export function main() {
 
       describe('ngOnChanges', () => {
         it('should be true when the directive has the ngOnChanges method', () => {
-          expect(hasLifecycleHook(LifecycleHooks.OnChanges, DirectiveWithOnChangesMethod))
-              .toBe(true);
+          expect(hasLifecycleHook(Hooks.OnChanges, DirectiveWithOnChangesMethod)).toBe(true);
         });
 
-        it('should be false otherwise', () => {
-          expect(hasLifecycleHook(LifecycleHooks.OnChanges, DirectiveNoHooks)).toBe(false);
-        });
+        it('should be false otherwise',
+           () => { expect(hasLifecycleHook(Hooks.OnChanges, DirectiveNoHooks)).toBe(false); });
       });
 
       describe('ngOnDestroy', () => {
         it('should be true when the directive has the ngOnDestroy method', () => {
-          expect(hasLifecycleHook(LifecycleHooks.OnDestroy, DirectiveWithOnDestroyMethod))
-              .toBe(true);
+          expect(hasLifecycleHook(Hooks.OnDestroy, DirectiveWithOnDestroyMethod)).toBe(true);
         });
 
-        it('should be false otherwise', () => {
-          expect(hasLifecycleHook(LifecycleHooks.OnDestroy, DirectiveNoHooks)).toBe(false);
-        });
+        it('should be false otherwise',
+           () => { expect(hasLifecycleHook(Hooks.OnDestroy, DirectiveNoHooks)).toBe(false); });
       });
 
       describe('ngOnInit', () => {
-        it('should be true when the directive has the ngOnInit method', () => {
-          expect(hasLifecycleHook(LifecycleHooks.OnInit, DirectiveWithOnInitMethod)).toBe(true);
-        });
+        it('should be true when the directive has the ngOnInit method',
+           () => { expect(hasLifecycleHook(Hooks.OnInit, DirectiveWithOnInitMethod)).toBe(true); });
 
-        it('should be false otherwise', () => {
-          expect(hasLifecycleHook(LifecycleHooks.OnInit, DirectiveNoHooks)).toBe(false);
-        });
+        it('should be false otherwise',
+           () => { expect(hasLifecycleHook(Hooks.OnInit, DirectiveNoHooks)).toBe(false); });
       });
 
       describe('ngDoCheck', () => {
         it('should be true when the directive has the ngDoCheck method', () => {
-          expect(hasLifecycleHook(LifecycleHooks.DoCheck, DirectiveWithOnCheckMethod)).toBe(true);
+          expect(hasLifecycleHook(Hooks.DoCheck, DirectiveWithOnCheckMethod)).toBe(true);
         });
 
-        it('should be false otherwise', () => {
-          expect(hasLifecycleHook(LifecycleHooks.DoCheck, DirectiveNoHooks)).toBe(false);
-        });
+        it('should be false otherwise',
+           () => { expect(hasLifecycleHook(Hooks.DoCheck, DirectiveNoHooks)).toBe(false); });
       });
 
       describe('ngAfterContentInit', () => {
         it('should be true when the directive has the ngAfterContentInit method', () => {
-          expect(hasLifecycleHook(
-                     LifecycleHooks.AfterContentInit, DirectiveWithAfterContentInitMethod))
+          expect(hasLifecycleHook(Hooks.AfterContentInit, DirectiveWithAfterContentInitMethod))
               .toBe(true);
         });
 
         it('should be false otherwise', () => {
-          expect(hasLifecycleHook(LifecycleHooks.AfterContentInit, DirectiveNoHooks)).toBe(false);
+          expect(hasLifecycleHook(Hooks.AfterContentInit, DirectiveNoHooks)).toBe(false);
         });
       });
 
       describe('ngAfterContentChecked', () => {
         it('should be true when the directive has the ngAfterContentChecked method', () => {
-          expect(hasLifecycleHook(
-                     LifecycleHooks.AfterContentChecked, DirectiveWithAfterContentCheckedMethod))
+          expect(
+              hasLifecycleHook(Hooks.AfterContentChecked, DirectiveWithAfterContentCheckedMethod))
               .toBe(true);
         });
 
         it('should be false otherwise', () => {
-          expect(hasLifecycleHook(LifecycleHooks.AfterContentChecked, DirectiveNoHooks))
-              .toBe(false);
+          expect(hasLifecycleHook(Hooks.AfterContentChecked, DirectiveNoHooks)).toBe(false);
         });
       });
 
 
       describe('ngAfterViewInit', () => {
         it('should be true when the directive has the ngAfterViewInit method', () => {
-          expect(hasLifecycleHook(LifecycleHooks.AfterViewInit, DirectiveWithAfterViewInitMethod))
+          expect(hasLifecycleHook(Hooks.AfterViewInit, DirectiveWithAfterViewInitMethod))
               .toBe(true);
         });
 
-        it('should be false otherwise', () => {
-          expect(hasLifecycleHook(LifecycleHooks.AfterViewInit, DirectiveNoHooks)).toBe(false);
-        });
+        it('should be false otherwise',
+           () => { expect(hasLifecycleHook(Hooks.AfterViewInit, DirectiveNoHooks)).toBe(false); });
       });
 
       describe('ngAfterViewChecked', () => {
         it('should be true when the directive has the ngAfterViewChecked method', () => {
-          expect(hasLifecycleHook(
-                     LifecycleHooks.AfterViewChecked, DirectiveWithAfterViewCheckedMethod))
+          expect(hasLifecycleHook(Hooks.AfterViewChecked, DirectiveWithAfterViewCheckedMethod))
               .toBe(true);
         });
 
         it('should be false otherwise', () => {
-          expect(hasLifecycleHook(LifecycleHooks.AfterViewChecked, DirectiveNoHooks)).toBe(false);
+          expect(hasLifecycleHook(Hooks.AfterViewChecked, DirectiveNoHooks)).toBe(false);
         });
       });
     });
@@ -111,7 +100,7 @@ export function main() {
 class DirectiveNoHooks {}
 
 class DirectiveWithOnChangesMethod {
-  ngOnChanges(_: any /** TODO #9100 */) {}
+  ngOnChanges(_: SimpleChanges) {}
 }
 
 class DirectiveWithOnInitMethod {