From be06a44861bd589eca57aa1ae8408e87871ebd4a Mon Sep 17 00:00:00 2001 From: Pete Bacon Darwin Date: Fri, 8 May 2020 13:33:47 +0100 Subject: [PATCH] Revert "test(compiler-cli): ensure reflection tests are not brittle to case-sensitivity (#36968)" (#37003) This reverts commit dcf1dcb757d523bb2347fb7dfecb5985a1106ed7. The changes to the case-sensitivity handling in #36968 caused multiple projects to fail to build. See #36992, #36993 and #37000. The issue is related to the logical path handling. But it is felt that it is safer to revert the entire PR and then to investigate further. PR Close #37003 --- .../compiler-cli/src/ngtsc/reflection/test/ts_host_spec.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/compiler-cli/src/ngtsc/reflection/test/ts_host_spec.ts b/packages/compiler-cli/src/ngtsc/reflection/test/ts_host_spec.ts index e9830f2160..5210047cbe 100644 --- a/packages/compiler-cli/src/ngtsc/reflection/test/ts_host_spec.ts +++ b/packages/compiler-cli/src/ngtsc/reflection/test/ts_host_spec.ts @@ -6,7 +6,7 @@ * found in the LICENSE file at https://angular.io/license */ import * as ts from 'typescript'; -import {absoluteFrom, getSourceFileOrError} from '../../file_system'; +import {absoluteFrom} from '../../file_system'; import {runInEachFileSystem} from '../../file_system/testing'; import {getDeclaration, makeProgram} from '../../testing'; import {CtorParameter} from '../src/host'; @@ -329,8 +329,8 @@ runInEachFileSystem(() => { } else if (directTargetDecl === null) { return fail('No declaration found for DirectTarget'); } - expect(targetDecl.node!.getSourceFile()) - .toBe(getSourceFileOrError(program, _('/node_modules/absolute/index.ts'))); + expect(targetDecl.node!.getSourceFile().fileName) + .toBe(_('/node_modules/absolute/index.ts')); expect(ts.isClassDeclaration(targetDecl.node!)).toBe(true); expect(directTargetDecl.viaModule).toBe('absolute'); expect(directTargetDecl.node).toBe(targetDecl.node);