cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(dart/transform): Remove unnecessary .ng_deps.dart files

Browse Source 
Removes `.ng_deps.dart` files which

1. Do not register any `@Injectable` classes
2. Do not call `initReflector` on any other `.ng_deps.dart` files.

Closes #1929
This commit is contained in:
Tim Blasi
2015-05-22 14:15:18 -07:00
parent cda35101df
commit c065fb1422
15 changed files with 166 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
modules/angular2/test/transform/directive_processor/all_tests.dart
View File

@ -50,13 +50,18 @@ void _testNgDeps(String name, String inputPath,
reader.addAsset(assetId, await reader.readAsString(inputId));
inputId = assetId;
}
var annotationMatcher = new AnnotationMatcher()..addAll(customDescriptors);
var output = formatter
.format(await createNgDeps(reader, inputId, annotationMatcher));
var expectedPath = path.join(path.dirname(inputPath), 'expected',
path.basename(inputPath).replaceFirst('.dart', '.ng_deps.dart'));
var expectedId = _assetIdForPath(expectedPath);
expect(output).toEqual(await reader.readAsString(expectedId));
var annotationMatcher = new AnnotationMatcher()..addAll(customDescriptors);
var output = await createNgDeps(reader, inputId, annotationMatcher);
if (output == null) {
expect(await reader.hasInput(expectedId)).toBeFalse();
} else {
expect(formatter.format(output))
.toEqual(await reader.readAsString(expectedId));
}
});
}

9
modules/angular2/test/transform/directive_processor/custom_metadata/expected/bad_soup.ng_deps.dart
View File

@ -1,9 +0,0 @@
library dinner.bad_soup.ng_deps.dart;
import 'bad_soup.dart';
var _visited = false;
void initReflector(reflector) {
if (_visited) return;
_visited = true;
}

5
modules/angular2/test/transform/integration/list_of_types_files/expected/bar.ng_deps.dart
View File

@ -2,10 +2,7 @@ library bar.ng_deps.dart;
import 'bar.dart';
import 'package:angular2/src/core/annotations_impl/annotations.dart';
import 'package:angular2/src/core/annotations_impl/annotations.ng_deps.dart'
as i0;
import 'foo.dart';
import 'foo.ng_deps.dart' as i1;
var _visited = false;
void initReflector(reflector) {
@ -18,6 +15,4 @@ void initReflector(reflector) {
'annotations':
const [const Component(componentServices: const [MyContext])]
});
i0.initReflector(reflector);
i1.initReflector(reflector);
}

3
modules/angular2/test/transform/integration/simple_annotation_files/expected/bar.ng_deps.dart
View File

@ -2,8 +2,6 @@ library bar.ng_deps.dart;
import 'bar.dart';
import 'package:angular2/src/core/annotations_impl/annotations.dart';
import 'package:angular2/src/core/annotations_impl/annotations.ng_deps.dart'
as i0;
var _visited = false;
void initReflector(reflector) {
@ -15,5 +13,4 @@ void initReflector(reflector) {
'parameters': const [],
'annotations': const [const Component(selector: '[soup]')]
});
i0.initReflector(reflector);
}

4
modules/angular2/test/transform/integration/simple_annotation_files/expected/index.ng_deps.dart
View File

@ -2,16 +2,14 @@ library web_foo.ng_deps.dart;
import 'index.dart';
import 'package:angular2/src/core/application.dart';
import 'package:angular2/src/core/application.ng_deps.dart' as i0;
import 'package:angular2/src/reflection/reflection.dart';
import 'index.ng_deps.dart' as ngStaticInit0;
import 'bar.dart';
import 'bar.ng_deps.dart' as i1;
import 'bar.ng_deps.dart' as i0;
var _visited = false;
void initReflector(reflector) {
if (_visited) return;
_visited = true;
i0.initReflector(reflector);
i1.initReflector(reflector);
}

3
modules/angular2/test/transform/integration/synthetic_ctor_files/expected/bar.ng_deps.dart
View File

@ -2,8 +2,6 @@ library bar.ng_deps.dart;
import 'bar.dart';
import 'package:angular2/src/core/annotations_impl/annotations.dart';
import 'package:angular2/src/core/annotations_impl/annotations.ng_deps.dart'
as i0;
var _visited = false;
void initReflector(reflector) {
@ -15,5 +13,4 @@ void initReflector(reflector) {
'parameters': const [],
'annotations': const [const Component(selector: '[soup]')]
});
i0.initReflector(reflector);
}

5
modules/angular2/test/transform/integration/two_annotations_files/expected/bar.ng_deps.dart
View File

@ -2,10 +2,7 @@ library bar.ng_deps.dart;
import 'bar.dart';
import 'package:angular2/src/core/annotations_impl/annotations.dart';
import 'package:angular2/src/core/annotations_impl/annotations.ng_deps.dart'
as i0;
import 'package:angular2/src/core/annotations_impl/view.dart';
import 'package:angular2/src/core/annotations_impl/view.ng_deps.dart' as i1;
var _visited = false;
void initReflector(reflector) {
@ -20,6 +17,4 @@ void initReflector(reflector) {
const View(template: 'Salad')
]
});
i0.initReflector(reflector);
i1.initReflector(reflector);
}

5
modules/angular2/test/transform/integration/two_deps_files/expected/bar.ng_deps.dart
View File

@ -2,10 +2,7 @@ library bar.ng_deps.dart;
import 'bar.dart';
import 'package:angular2/src/core/annotations_impl/annotations.dart';
import 'package:angular2/src/core/annotations_impl/annotations.ng_deps.dart'
as i0;
import 'foo.dart' as prefix;
import 'foo.ng_deps.dart' as i1;
var _visited = false;
void initReflector(reflector) {
@ -18,6 +15,4 @@ void initReflector(reflector) {
'parameters': const [const [prefix.MyContext], const [String]],
'annotations': const [const Component(selector: 'soup')]
});
i0.initReflector(reflector);
i1.initReflector(reflector);
}