chore(build): faster feedback for broken lint

Originally we ran gulp enforce-format at the beginning of the build.
This was annoying because you came back from lunch to find that no tests
ran so you have to start your PR over.
Then we changed it to run the linters at the end. This is annoying because
you might be ready to merge to master, and could have fixed the lint
issues immediately, but now much wait for another PR.
The solution is to run the lint checks in another build. This marks
your PR red very early, but you still get the feedback of whether the
tests are passing.

scripts/ci/build_and_test.sh

@@ -8,16 +8,14 @@ echo ===========================================================================
 SCRIPT_DIR=$(dirname $0)
 cd $SCRIPT_DIR/../..
 
-if [ "$MODE" = "dart_experimental" ]
-then
+if [ "$MODE" = "dart_experimental" ]; then
   ${SCRIPT_DIR}/build_$MODE.sh
+elif [ "$MODE" = "saucelabs" ]; then
+  ${SCRIPT_DIR}/test_$MODE.sh
+elif [ "$MODE" = "lint" ]; then
+  ./node_modules/.bin/gulp static-checks
 else
-  if [ "$MODE" = "saucelabs" ]
-  then
-    ${SCRIPT_DIR}/test_$MODE.sh
-  else
-    ${SCRIPT_DIR}/build_$MODE.sh
-    mkdir deploy; tar -czpf deploy/dist.tgz -C dist .
-    ${SCRIPT_DIR}/test_$MODE.sh
-  fi
+  ${SCRIPT_DIR}/build_$MODE.sh
+  mkdir deploy; tar -czpf deploy/dist.tgz -C dist .
+  ${SCRIPT_DIR}/test_$MODE.sh
 fi

scripts/ci/test_js.sh

@@ -15,4 +15,3 @@ fi
 ./node_modules/.bin/gulp pre-test-checks
 ./node_modules/.bin/gulp test.js --browsers=${KARMA_BROWSERS:-ChromeCanary}
 ${SCRIPT_DIR}/test_e2e_js.sh
-./node_modules/.bin/gulp post-test-checks