From c16a79df5cf3e9a293e2565a1b0ca1fb106b520c Mon Sep 17 00:00:00 2001 From: Joey Perrott Date: Wed, 27 Nov 2019 13:14:11 -0800 Subject: [PATCH] build: add failure message if compile build variable for angular/angular usage (#34109) To quicken migration for our own developers away from using compile=aot for setting ivy, we actually fail the build process if the compile build variable is used with a message to use our config flags instead. PR Close #34109 --- packages/bazel/src/ng_module.bzl | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/packages/bazel/src/ng_module.bzl b/packages/bazel/src/ng_module.bzl index 7191de737b..96e2c579a6 100644 --- a/packages/bazel/src/ng_module.bzl +++ b/packages/bazel/src/ng_module.bzl @@ -35,10 +35,17 @@ def is_ivy_enabled(ctx): Returns: Boolean, Whether the ivy compiler should be used. """ + if "compile" in ctx.var and ctx.workspace_name == "angular": + fail( + msg = "Setting ViewEngine/Ivy using --define=compile is deprecated, please use " + + "--config=ivy or --config=view-engine instead.", + attr = "ng_module", + ) + # TODO(josephperrott): Remove configuration via compile=aot define flag. if ctx.var.get("compile", None) == "aot": print("Setting ViewEngine/Ivy using the compile build variable (--define=compile=*) " + - "is deprecated, please use the angular_ivy_enabled build variable instead.") + "is deprecated, please use the --define=angular_ivy_enabled=True instead.") return True if ctx.var.get("angular_ivy_enabled", None) == "True":