From c208f9746195d7f62e05041f32353bc2d195671e Mon Sep 17 00:00:00 2001 From: Peter Bacon Darwin Date: Tue, 21 Feb 2017 17:54:57 +0000 Subject: [PATCH] fix(aio): correctly handle "empty" region names --- aio/transforms/examples-package/services/region-parser.js | 2 +- aio/transforms/examples-package/services/region-parser.spec.js | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/aio/transforms/examples-package/services/region-parser.js b/aio/transforms/examples-package/services/region-parser.js index 19556bcc0d..4f144150a9 100644 --- a/aio/transforms/examples-package/services/region-parser.js +++ b/aio/transforms/examples-package/services/region-parser.js @@ -106,7 +106,7 @@ function regionParserImpl(contents, fileType) { } function getRegionNames(input) { - return input.split(',').map(name => name.trim()).filter(name => name.length > 0); + return (input.trim() === '') ? [] : input.split(',').map(name => name.trim()); } function removeLast(array, item) { diff --git a/aio/transforms/examples-package/services/region-parser.spec.js b/aio/transforms/examples-package/services/region-parser.spec.js index c8c9a62db1..a0e3fc34ca 100644 --- a/aio/transforms/examples-package/services/region-parser.spec.js +++ b/aio/transforms/examples-package/services/region-parser.spec.js @@ -145,8 +145,9 @@ describe('regionParser service', () => { it('should parse multiple region names separated by commas', () => { const output = regionParser( t('/* #docregion , A, B */', 'abc', '/* #enddocregion B */', '/* #docregion C */', 'xyz', - '/* #enddocregion A, C, */'), + '/* #enddocregion A, C */', '123', '/* #enddocregion */'), 'test-type'); + expect(output.regions['']).toEqual(t('abc', 'xyz', '123')); expect(output.regions['A']).toEqual(t('abc', 'xyz')); expect(output.regions['B']).toEqual(t('abc')); expect(output.regions['C']).toEqual(t('xyz'));