fix(router): make remove trailing slash consistent with URL params

closes #16069
This commit is contained in:
Jason Aden
2017-05-26 11:02:31 -07:00
committed by Victor Berchet
parent 1408357198
commit c20f60b144
2 changed files with 51 additions and 2 deletions

View File

@ -168,9 +168,16 @@ export class Location {
}
/**
* If url has a trailing slash, remove it, otherwise return url as is.
* If url has a trailing slash, remove it, otherwise return url as is. This
* method looks for the first occurence of either #, ?, or the end of the
* line as `/` characters after any of these should not be replaced.
*/
public static stripTrailingSlash(url: string): string { return url.replace(/\/$/, ''); }
public static stripTrailingSlash(url: string): string {
const match = url.match(/#|\?|$/);
const pathEndIdx = match && match.index || url.length;
const droppedSlashIdx = pathEndIdx - (url[pathEndIdx - 1] === '/' ? 1 : 0);
return url.slice(0, droppedSlashIdx) + url.slice(pathEndIdx);
}
}
function _stripBaseHref(baseHref: string, url: string): string {