cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(animations): ensure the web-animations driver properly handles empty keyframes (#20648)

Browse Source 
Closes #15858

PR Close #20648
This commit is contained in:
Matias Niemelä 2017-11-27 14:40:09 -08:00 committed by Jason Aden
parent 10771d0bd8
commit c26e1bba1d
2 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/animations/browser/src/render/web_animations/web_animations_player.ts
View File

@ -65,7 +65,7 @@ export class WebAnimationsPlayer implements AnimationPlayer {
const keyframes = this.keyframes.map(styles => copyStyles(styles, false)); const keyframes = this.keyframes.map(styles => copyStyles(styles, false));
const previousStyleProps = Object.keys(this.previousStyles); const previousStyleProps = Object.keys(this.previousStyles);
if (previousStyleProps.length) { if (previousStyleProps.length && keyframes.length) {
let startingKeyframe = keyframes[0]; let startingKeyframe = keyframes[0];
let missingStyleProps: string[] = []; let missingStyleProps: string[] = [];
previousStyleProps.forEach(prop => { previousStyleProps.forEach(prop => {

18
packages/animations/browser/test/render/web_animations/web_animations_player_spec.ts
View File

@ -33,6 +33,24 @@ export function main() {
expect(p.log).toEqual(['pause', 'play']); expect(p.log).toEqual(['pause', 'play']);
}); });
it('should allow an empty set of keyframes with a set of previous styles', () => {
const previousKeyframes = [
{opacity: 0, offset: 0},
{opacity: 1, offset: 1},
];
const previousPlayer = new WebAnimationsPlayer(element, previousKeyframes, {duration: 1000});
previousPlayer.play();
previousPlayer.finish();
previousPlayer.beforeDestroy();
const EMPTY_KEYFRAMES: any[] = [];
const player =
new WebAnimationsPlayer(element, EMPTY_KEYFRAMES, {duration: 1000}, [previousPlayer]);
player.play();
player.destroy();
});
it('should not pause the player if created and started before initialized', () => { it('should not pause the player if created and started before initialized', () => {
const keyframes = [ const keyframes = [
{opacity: 0, offset: 0}, {opacity: 0, offset: 0},