From c2aed033bad700fbc927bf6b76d0b9e2b439fd00 Mon Sep 17 00:00:00 2001 From: Alex Rickabaugh Date: Fri, 12 Jun 2020 17:34:26 +0000 Subject: [PATCH] ci(compiler-cli): exempt compiler-cli .bazel files from dev-infra approval (#37558) Previously, dev-infra approval (via PullApprove) was required for all .bazel files in the monorepo, including those in packages/compiler-cli. The compiler-cli package is a little special in this sense: * it's not shipped to NPM in the APF * it uses lots of internal subpackages to organize and test its code As a result: * changes to compiler-cli BUILD.bazel files are not user visible and don't have larger implications for the packages published to NPM, unlike changes to other BUILD.bazel files in the repo * the requirement for dev-infra approval for BUILD.bazel changes is overly burdensome, because compiler-cli build files change more rapidly than those of other packages. This commit exempts the compiler-cli's build files from the requirement for dev-infra approval. It will be sufficient for such files to be approved by the normal compiler reviewers. PR Close #37558 --- .pullapprove.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.pullapprove.yml b/.pullapprove.yml index f004c06510..17edac2dfa 100644 --- a/.pullapprove.yml +++ b/.pullapprove.yml @@ -1036,7 +1036,7 @@ groups: conditions: - *can-be-global-approved - > - contains_any_globs(files.exclude("CHANGELOG.md"), [ + contains_any_globs(files.exclude("CHANGELOG.md").exclude("packages/compiler-cli/**/BUILD.bazel"), [ '*', '.circleci/**', '.devcontainer/**',