From c387933d3c1283dfa0063186f541cfa4c9342dc8 Mon Sep 17 00:00:00 2001 From: Andrew Scott Date: Mon, 27 Jul 2020 16:26:31 -0700 Subject: [PATCH] ci: roll back phased review conditions (#38257) It was determined that the list of 'pending' groups also included inactive groups. That means that the 'no-groups-above-this-pending' would generally fail because there's almost always some inactive group above it. This commit removes the conditions for phased review while we investigate if the inactive groups can be excluded. PR Close #38257 --- .pullapprove.yml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.pullapprove.yml b/.pullapprove.yml index 6800bd3a7e..15dfd30242 100644 --- a/.pullapprove.yml +++ b/.pullapprove.yml @@ -1160,8 +1160,6 @@ groups: public-api: <<: *defaults conditions: - - *no-groups-above-this-pending - - *no-groups-above-this-rejected - *can-be-global-approved - > contains_any_globs(files, [ @@ -1194,8 +1192,6 @@ groups: size-tracking: <<: *defaults conditions: - - *no-groups-above-this-pending - - *no-groups-above-this-rejected - *can-be-global-approved - > contains_any_globs(files, [ @@ -1222,8 +1218,6 @@ groups: circular-dependencies: <<: *defaults conditions: - - *no-groups-above-this-pending - - *no-groups-above-this-rejected - *can-be-global-approved - > contains_any_globs(files, [