cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

build: update to nodejs rules 0.41.0 (#33996)

Browse Source 
This bring is changes to the @nodejs repository required for https://github.com/angular/angular/pull/33927. See release notes for more details: https://github.com/bazelbuild/rules_nodejs/releases/tag/0.41.0.

rules_nodejs is approaching 1.0 and breaking changes for that release are being made more frequently. In this release, the ts_devserver API changed and it no longer injects html script tags into a provided index.html file. The diff on this commit is large as this breaking change affects quite a few tests.

Also note that we don’t update @angular/bazel schematics and integration/bazel as 0.41.0 is not a recommended update for angular users yet due to the breaking changes in ts_devserver & web_package (now named pkg_web). When a suitable plain npm package that is in progress is finished then it will be possible to easily replace the html injection functionality removed from ts_devserver & pkg_web.

PR Close #33996
This commit is contained in:
Greg Magolan
2019-11-22 13:12:05 -08:00
committed by Miško Hevery
parent 3f68377c3d
commit c4335e2817
99 changed files with 484 additions and 476 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
modules/benchmarks/src/class_bindings/BUILD.bazel
View File

@ -41,12 +41,10 @@ ng_rollup_bundle(
ts_devserver(
name = "prodserver",
index_html = "index.html",
bootstrap = ["//packages/zone.js/dist:zone.js"],
port = 4200,
static_files = [
":bundle.min_debug.es2015.js",
"//packages/zone.js/dist:zone.js",
],
static_files = ["index.html"],
deps = [":bundle.min_debug.es2015.js"],
)
benchmark_test(

2
modules/benchmarks/src/class_bindings/index.html
View File

@ -20,6 +20,8 @@
<h1>Class Binding Benchmark</h1>
<app-component>Loading...</app-component>
<!--default load location for ts_devserver-->
<script src="/_/ts_scripts.js"></script>
</body>
</html>

19
modules/benchmarks/src/expanding_rows/BUILD.bazel
View File

@ -42,31 +42,22 @@ ng_rollup_bundle(
ts_devserver(
name = "prodserver",
index_html = "index.html",
bootstrap = ["//packages/zone.js/dist:zone.js"],
port = 4200,
static_files = [
"//packages/zone.js/dist:zone.js",
],
deps = [
":bundle.min_debug.es2015.js",
],
static_files = ["index.html"],
deps = [":bundle.min_debug.es2015.js"],
)
ts_devserver(
name = "devserver",
bootstrap = ["//packages/zone.js/dist:zone.js"],
entry_module = "angular/modules/benchmarks/src/expanding_rows/index_aot",
# Uncomment this to run devserver. This is due to limitation of ts_devserver
# that produces `index.html` by default so there cannot be two ts_devserver
# rules in a single Bazel package.
# index_html = "index.html",
port = 4200,
scripts = [
"@npm//:node_modules/tslib/tslib.js",
"//tools/rxjs:rxjs_umd_modules",
],
static_files = [
"//packages/zone.js/dist:zone.js",
],
static_files = ["index.html"],
deps = [":application_lib"],
)

3
modules/benchmarks/src/expanding_rows/index.html
View File

@ -12,6 +12,9 @@
<div id="rendererMode">...</div>
<benchmark-root>Loading...</benchmark-root>
<!--default load location for ts_devserver-->
<script src="/_/ts_scripts.js"></script>
</body>
</html>

10
modules/benchmarks/src/largeform/ng2/BUILD.bazel
View File

@ -26,17 +26,17 @@ ng_module(
ts_devserver(
name = "devserver",
bootstrap = [
"@npm//:node_modules/reflect-metadata/Reflect.js",
"//packages/zone.js/dist:zone.js",
],
entry_module = "angular/modules/benchmarks/src/largeform/ng2/index",
index_html = "index.html",
port = 4200,
scripts = [
"@npm//:node_modules/tslib/tslib.js",
"//tools/rxjs:rxjs_umd_modules",
],
static_files = [
"@npm//:node_modules/reflect-metadata/Reflect.js",
"//packages/zone.js/dist:zone.js",
],
static_files = ["index.html"],
tags = ["fixme-ivy-aot"],
deps = [":ng2"],
)

3
modules/benchmarks/src/largeform/ng2/index.html
View File

@ -19,5 +19,8 @@
<div>
<app id="root">Loading...</app>
</div>
<!--default load location for ts_devserver-->
<script src="/_/ts_scripts.js"></script>
</body>
</html>

2
modules/benchmarks/src/largetable/baseline/BUILD.bazel
View File

@ -17,8 +17,8 @@ ts_library(
ts_devserver(
name = "devserver",
entry_module = "angular/modules/benchmarks/src/largetable/baseline/index",
index_html = "index.html",
port = 4200,
static_files = ["index.html"],
deps = [":baseline"],
)

3
modules/benchmarks/src/largetable/baseline/index.html
View File

@ -28,5 +28,8 @@
<div>
<largetable id="root">Loading...</largetable>
</div>
<!--default load location for ts_devserver-->
<script src="/_/ts_scripts.js"></script>
</body>
</html>

2
modules/benchmarks/src/largetable/incremental_dom/BUILD.bazel
View File

@ -17,9 +17,9 @@ ts_library(
ts_devserver(
name = "devserver",
entry_module = "angular/modules/benchmarks/src/largetable/incremental_dom/index",
index_html = "index.html",
port = 4200,
static_files = [
"index.html",
"@npm//:node_modules/incremental-dom/dist/incremental-dom.js",
],
deps = [":incremental_dom"],

4
modules/benchmarks/src/largetable/incremental_dom/index.html
View File

@ -28,5 +28,9 @@
<div>
<largetable id="root"></largetable>
</div>
<script src="/npm/node_modules/incremental-dom/dist/incremental-dom.js"></script>
<!--default load location for ts_devserver-->
<script src="/_/ts_scripts.js"></script>
</body>
</html>

4
modules/benchmarks/src/largetable/iv/BUILD.bazel
View File

@ -5,9 +5,9 @@ package(default_visibility = ["//modules/benchmarks:__subpackages__"])
ts_devserver(
name = "devserver",
index_html = "index.html",
bootstrap = ["largetable.js"],
port = 4200,
static_files = ["largetable.js"],
static_files = ["index.html"],
)
benchmark_test(

3
modules/benchmarks/src/largetable/iv/index.html
View File

@ -28,5 +28,8 @@
<div>
<largetable id="root"></largetable>
</div>
<!--default load location for ts_devserver-->
<script src="/_/ts_scripts.js"></script>
</body>
</html>

8
modules/benchmarks/src/largetable/ng2/BUILD.bazel
View File

@ -34,12 +34,10 @@ ng_rollup_bundle(
ts_devserver(
name = "prodserver",
index_html = "index.html",
bootstrap = ["//packages/zone.js/dist:zone.js"],
port = 4200,
static_files = [
":bundle.min_debug.es2015.js",
"//packages/zone.js/dist:zone.js",
],
static_files = ["index.html"],
deps = [":bundle.min_debug.es2015.js"],
)
benchmark_test(

3
modules/benchmarks/src/largetable/ng2/index.html
View File

@ -28,5 +28,8 @@
<div>
<largetable id="root">Loading...</largetable>
</div>
<!--default load location for ts_devserver-->
<script src="/_/ts_scripts.js"></script>
</body>
</html>

10
modules/benchmarks/src/largetable/ng2_switch/BUILD.bazel
View File

@ -22,17 +22,17 @@ ng_module(
ts_devserver(
name = "devserver",
bootstrap = [
"@npm//:node_modules/reflect-metadata/Reflect.js",
"//packages/zone.js/dist:zone.js",
],
entry_module = "angular/modules/benchmarks/src/largetable/ng2_switch/index",
index_html = "index.html",
port = 4200,
scripts = [
"@npm//:node_modules/tslib/tslib.js",
"//tools/rxjs:rxjs_umd_modules",
],
static_files = [
"@npm//:node_modules/reflect-metadata/Reflect.js",
"//packages/zone.js/dist:zone.js",
],
static_files = ["index.html"],
deps = [":ng2_switch"],
)

3
modules/benchmarks/src/largetable/ng2_switch/index.html
View File

@ -28,5 +28,8 @@
<div>
<largetable id="root">Loading...</largetable>
</div>
<!--default load location for ts_devserver-->
<script src="/_/ts_scripts.js"></script>
</body>
</html>

2
modules/benchmarks/src/largetable/render3/BUILD.bazel
View File

@ -32,8 +32,8 @@ ng_rollup_bundle(
ts_devserver(
name = "devserver",
index_html = "index.html",
port = 4200,
static_files = ["index.html"],
tags = ["ivy-only"],
deps = [
":bundle.min_debug.js",

3
modules/benchmarks/src/largetable/render3/index.html
View File

@ -28,6 +28,7 @@
<largetable id="root"></largetable>
</div>
<!--default load location for ts_devserver-->
<script src="/_/ts_scripts.js"></script>
</body>
</html>

2
modules/benchmarks/src/tree/baseline/BUILD.bazel
View File

@ -17,8 +17,8 @@ ts_library(
ts_devserver(
name = "devserver",
entry_module = "angular/modules/benchmarks/src/tree/baseline/index",
index_html = "index.html",
port = 4200,
static_files = ["index.html"],
deps = [":baseline"],
)

3
modules/benchmarks/src/tree/baseline/index.html
View File

@ -25,5 +25,8 @@
<div>
<tree id="root">Loading...</tree>
</div>
<!--default load location for ts_devserver-->
<script src="/_/ts_scripts.js"></script>
</body>
</html>

2
modules/benchmarks/src/tree/incremental_dom/BUILD.bazel
View File

@ -18,9 +18,9 @@ ts_library(
ts_devserver(
name = "devserver",
entry_module = "angular/modules/benchmarks/src/tree/incremental_dom/index",
index_html = "index.html",
port = 4200,
static_files = [
"index.html",
"@npm//:node_modules/incremental-dom/dist/incremental-dom.js",
],
deps = [":incremental_dom"],

4
modules/benchmarks/src/tree/incremental_dom/index.html
View File

@ -25,5 +25,9 @@
<div>
<tree id="root"></tree>
</div>
<script src="/npm/node_modules/incremental-dom/dist/incremental-dom.js"></script>
<!--default load location for ts_devserver-->
<script src="/_/ts_scripts.js"></script>
</body>
</html>

4
modules/benchmarks/src/tree/iv/BUILD.bazel
View File

@ -5,9 +5,9 @@ package(default_visibility = ["//modules/benchmarks:__subpackages__"])
ts_devserver(
name = "devserver",
index_html = "index.html",
bootstrap = ["tree.js"],
port = 4200,
static_files = ["tree.js"],
static_files = ["index.html"],
)
benchmark_test(

3
modules/benchmarks/src/tree/iv/index.html
View File

@ -28,5 +28,8 @@
Change detection runs:<span id="numberOfChecks"></span>
</div>
<div id="root"></div>
<!--default load location for ts_devserver-->
<script src="/_/ts_scripts.js"></script>
</body>
</html>

6
modules/benchmarks/src/tree/ng1/BUILD.bazel
View File

@ -16,12 +16,10 @@ ts_library(
ts_devserver(
name = "devserver",
bootstrap = ["@npm//:node_modules/angular/angular.js"],
entry_module = "angular/modules/benchmarks/src/tree/ng1/index",
index_html = "index.html",
port = 4200,
static_files = [
"@npm//:node_modules/angular/angular.js",
],
static_files = ["index.html"],
deps = [":ng1"],
)

3
modules/benchmarks/src/tree/ng1/index.html
View File

@ -30,5 +30,8 @@
<div>
<tree id="root" data="initData">Loading...</tree>
</div>
<!--default load location for ts_devserver-->
<script src="/_/ts_scripts.js"></script>
</body>
</html>

8
modules/benchmarks/src/tree/ng2/BUILD.bazel
View File

@ -34,12 +34,10 @@ ng_rollup_bundle(
ts_devserver(
name = "prodserver",
index_html = "index.html",
bootstrap = ["//packages/zone.js/dist:zone.js"],
port = 4200,
static_files = [
":bundle.min_debug.es2015.js",
"//packages/zone.js/dist:zone.js",
],
static_files = ["index.html"],
deps = [":bundle.min_debug.es2015.js"],
)
benchmark_test(

3
modules/benchmarks/src/tree/ng2/index.html
View File

@ -30,5 +30,8 @@
<div>
<tree id="root">Loading...</tree>
</div>
<!--default load location for ts_devserver-->
<script src="/_/ts_scripts.js"></script>
</body>
</html>

2
modules/benchmarks/src/tree/ng2_next/BUILD.bazel
View File

@ -20,12 +20,12 @@ ts_library(
ts_devserver(
name = "devserver",
entry_module = "angular/modules/benchmarks/src/tree/ng2_next/index",
index_html = "index.html",
port = 4200,
scripts = [
"@npm//:node_modules/tslib/tslib.js",
"//tools/rxjs:rxjs_umd_modules",
],
static_files = ["index.html"],
deps = [":ng2_next"],
)

3
modules/benchmarks/src/tree/ng2_next/index.html
View File

@ -30,5 +30,8 @@
<div>
<tree id="root">Loading...</tree>
</div>
<!--default load location for ts_devserver-->
<script src="/_/ts_scripts.js"></script>
</body>
</html>

10
modules/benchmarks/src/tree/ng2_static/BUILD.bazel
View File

@ -19,17 +19,17 @@ ts_library(
ts_devserver(
name = "devserver",
bootstrap = [
"@npm//:node_modules/reflect-metadata/Reflect.js",
"//packages/zone.js/dist:zone.js",
],
entry_module = "angular/modules/benchmarks/src/tree/ng2_static/index",
index_html = "index.html",
port = 4200,
scripts = [
"@npm//:node_modules/tslib/tslib.js",
"//tools/rxjs:rxjs_umd_modules",
],
static_files = [
"@npm//:node_modules/reflect-metadata/Reflect.js",
"//packages/zone.js/dist:zone.js",
],
static_files = ["index.html"],
deps = [":ng2_static"],
)

3
modules/benchmarks/src/tree/ng2_static/index.html
View File

@ -24,5 +24,8 @@
<div>
<tree id="root"></tree>
</div>
<!--default load location for ts_devserver-->
<script src="/_/ts_scripts.js"></script>
</body>
</html>

10
modules/benchmarks/src/tree/ng2_switch/BUILD.bazel
View File

@ -22,17 +22,17 @@ ng_module(
ts_devserver(
name = "devserver",
bootstrap = [
"@npm//:node_modules/reflect-metadata/Reflect.js",
"//packages/zone.js/dist:zone.js",
],
entry_module = "angular/modules/benchmarks/src/tree/ng2_switch/index",
index_html = "index.html",
port = 4200,
scripts = [
"@npm//:node_modules/tslib/tslib.js",
"//tools/rxjs:rxjs_umd_modules",
],
static_files = [
"@npm//:node_modules/reflect-metadata/Reflect.js",
"//packages/zone.js/dist:zone.js",
],
static_files = ["index.html"],
deps = [":ng2_switch"],
)

3
modules/benchmarks/src/tree/ng2_switch/index.html
View File

@ -25,5 +25,8 @@
<div>
<tree id="root">Loading...</tree>
</div>
<!--default load location for ts_devserver-->
<script src="/_/ts_scripts.js"></script>
</body>
</html>

6
modules/benchmarks/src/tree/render3/BUILD.bazel
View File

@ -31,12 +31,10 @@ ng_rollup_bundle(
ts_devserver(
name = "devserver",
index_html = "index.html",
port = 4200,
static_files = ["index.html"],
tags = ["ivy-only"],
deps = [
":bundle.min_debug.js",
],
deps = [":bundle.min_debug.js"],
)
benchmark_test(

2
modules/benchmarks/src/tree/render3/index.html
View File

@ -31,5 +31,7 @@
<tree id="root"></tree>
</div>
<!--default load location for ts_devserver-->
<script src="/_/ts_scripts.js"></script>
</body>
</html>

2
modules/benchmarks/src/tree/render3_function/BUILD.bazel
View File

@ -18,12 +18,12 @@ ts_library(
ts_devserver(
name = "devserver",
entry_module = "angular/modules/benchmarks/src/tree/render3_function/index",
index_html = "index.html",
port = 4200,
scripts = [
"@npm//:node_modules/tslib/tslib.js",
"//tools/rxjs:rxjs_umd_modules",
],
static_files = ["index.html"],
deps = [":render3_function_lib"],
)

3
modules/benchmarks/src/tree/render3_function/index.html
View File

@ -35,5 +35,8 @@
// TODO(mlaval): remove once we have a proper solution
ngDevMode = false;
</script>
<!--default load location for ts_devserver-->
<script src="/_/ts_scripts.js"></script>
</body>
</html>

5
modules/benchmarks/src/views/BUILD.bazel
View File

@ -38,17 +38,14 @@ ts_devserver(
ts_devserver(
name = "devserver",
data = [
"//packages/zone.js/dist:zone.js",
],
entry_module = "angular/modules/benchmarks/src/views/index",
index_html = "index.html",
scripts = [
"@npm//:node_modules/tslib/tslib.js",
"//tools/rxjs:rxjs_umd_modules",
],
serving_path = "/index.js",
static_files = [
"//packages/zone.js/dist:zone.js",
"index.html",
],
deps = [":application_lib"],