cargdev/angular
1
0
Fork 0
Code Issues 18 Pull Requests Actions Packages Projects Releases Wiki Activity

build: update to nodejs rules 0.41.0 (#33996)

Browse Source 
This bring is changes to the @nodejs repository required for https://github.com/angular/angular/pull/33927. See release notes for more details: https://github.com/bazelbuild/rules_nodejs/releases/tag/0.41.0.

rules_nodejs is approaching 1.0 and breaking changes for that release are being made more frequently. In this release, the ts_devserver API changed and it no longer injects html script tags into a provided index.html file. The diff on this commit is large as this breaking change affects quite a few tests.

Also note that we don’t update @angular/bazel schematics and integration/bazel as 0.41.0 is not a recommended update for angular users yet due to the breaking changes in ts_devserver & web_package (now named pkg_web). When a suitable plain npm package that is in progress is finished then it will be possible to easily replace the html injection functionality removed from ts_devserver & pkg_web.

PR Close #33996
This commit is contained in:
Greg Magolan
2019-11-22 13:12:05 -08:00
committed by Miško Hevery
parent 3f68377c3d
commit c4335e2817
99 changed files with 484 additions and 476 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
modules/playground/e2e_test/sourcemap/BUILD.bazel
View File

@ -1,11 +1,24 @@
load("//modules/playground/e2e_test:example_test.bzl", "example_test")
filegroup(
name = "protractor_web_test_data_workaroud",
srcs = ["//modules/playground/src/sourcemap:index.ts"],
)
# Work-around for protractor_web_test data not allowing files.
# TODO(gregmagolan): remove this work-around once this is fixed in rules_nodejs
# ```
# ERROR: /Users/greg/google/angular-2/modules/playground/e2e_test/sourcemap/BUILD.bazel:8:1:
# in data attribute of _protractor_web_test rule //modules/playground/e2e_test/sourcemap:protractor_tests_wrapped_test:
# source file '//modules/playground/src/sourcemap:index.ts' is misplaced here (expected no files). Since this rule was
# created by the macro 'example_test', the error might have been caused by the macro implementation
# ```
example_test(
name = "sourcemap",
srcs = glob(["**/*.ts"]),
data = [
":protractor_web_test_data_workaroud",
"//modules/playground/src/sourcemap",
"//modules/playground/src/sourcemap:index.ts",
],
server = "//modules/playground/src/sourcemap:devserver",
)