cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

build: update to nodejs rules 0.41.0 (#33996)

Browse Source 
This bring is changes to the @nodejs repository required for https://github.com/angular/angular/pull/33927. See release notes for more details: https://github.com/bazelbuild/rules_nodejs/releases/tag/0.41.0.

rules_nodejs is approaching 1.0 and breaking changes for that release are being made more frequently. In this release, the ts_devserver API changed and it no longer injects html script tags into a provided index.html file. The diff on this commit is large as this breaking change affects quite a few tests.

Also note that we don’t update @angular/bazel schematics and integration/bazel as 0.41.0 is not a recommended update for angular users yet due to the breaking changes in ts_devserver & web_package (now named pkg_web). When a suitable plain npm package that is in progress is finished then it will be possible to easily replace the html injection functionality removed from ts_devserver & pkg_web.

PR Close #33996
This commit is contained in:
Greg Magolan
2019-11-22 13:12:05 -08:00
committed by Miško Hevery
parent 3f68377c3d
commit c4335e2817
99 changed files with 484 additions and 476 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
packages/examples/upgrade/upgrade_example.bzl
View File

@ -45,18 +45,20 @@ def create_upgrade_example_targets(name, srcs, e2e_srcs, entry_module, assets =
name = "devserver",
port = 4200,
entry_module = entry_module,
static_files = [
additional_root_paths = ["angular/packages/examples"],
bootstrap = [
"//packages/zone.js/dist:zone.js",
"@npm//:node_modules/angular/angular.js",
"@npm//:node_modules/reflect-metadata/Reflect.js",
],
index_html = "//packages/examples:index.html",
static_files = [
"//packages/examples:index.html",
] + assets,
scripts = [
"@npm//:node_modules/tslib/tslib.js",
"//tools/rxjs:rxjs_umd_modules",
],
deps = [":%s_sources" % name],
data = assets,
)
protractor_web_test_suite(
@ -65,7 +67,6 @@ def create_upgrade_example_targets(name, srcs, e2e_srcs, entry_module, assets =
server = ":devserver",
deps = [
":%s_e2e_lib" % name,
"@npm//protractor",
"@npm//selenium-webdriver",
],
)