ci: check versions of non-local integration project dependencies (#33968)
In order to keep integration tests on CI as determinitstic as possible, we need to ensure that the same dependencies (including transitive ones) are installed each time. One way to ensure that is using a lockfile (such as `yarn.lock`) to pin the dependencies to exact versions. This works as long as the lockfile itself is in-sync with the corresponding `package.json`, which specifies the dependencies. Ideally, we would run `yarn install` with the `--frozen-lockfile` option to verify that the lockfile is in-sync with `package.json`, but we cannot do that for integration projects, because we want to be able to install the locally built Angular packages). Therefore, we must manually esnure that the integration project lockfiles remain in-sync, which is error-prone. This commit introduces a helper script that performs some checks on each project's (non-local) dependencies: - Ensure that exact versions (not version ranges) are specified in `package.json`. This reduces the probability of installing a breaking version of a direct or transitive dependency, in case of an out-of-sync lockfile. - Ensure that the lockfile is in-sync with `package.json` wrt these dependencies. While these checks are not full-proof, they provide yet another line of defense against indeterminism. PR Close #33968
This commit is contained in:

committed by
Miško Hevery

parent
60db3505f6
commit
c5584b2dbc
@ -55,6 +55,11 @@ for testDir in ${TEST_DIRS}; do
|
||||
cd $testDir
|
||||
rm -rf dist
|
||||
|
||||
# Ensure the versions of (non-local) dependencies are exact versions (not version ranges) and
|
||||
# in-sync between `package.json` and the lockfile.
|
||||
# (NOTE: This must be run before `yarn install`, which updates the lockfile.)
|
||||
node ../check-dependencies .
|
||||
|
||||
yarn install --cache-folder ../$cache
|
||||
yarn test || exit 1
|
||||
|
||||
|
Reference in New Issue
Block a user