cargdev/angular
1
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ivy): proper resolution of Enums in Component decorator (#27971)

Browse Source 
Prior to this change Component decorator was resolving `encapsulation` value a bit incorrectly, which resulted in `encapsulation: NaN` in compiled code. Now we resolve the value as Enum memeber and throw if it's not the case. As a part of this update, the `changeDetection` field handling is also added, the resolution logic is the same as the one used for `encapsulation` field.

PR Close #27971
This commit is contained in:
Andrew Kushnir
2019-01-07 16:35:06 -08:00
parent 142553abc6
commit c5ab3e8fd2
7 changed files with 122 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/compiler-cli/test/compliance/r3_view_compiler_styling_spec.ts
View File

@ -50,11 +50,11 @@ describe('compiler compliance: styling', () => {
const files = {
app: {
'spec.ts': `
import {Component, NgModule} from '@angular/core';
import {Component, NgModule, ViewEncapsulation} from '@angular/core';
@Component({
selector: "my-component",
encapsulation: ${ViewEncapsulation.None},
encapsulation: ViewEncapsulation.None,
styles: ["div.tall { height: 123px; }", ":host.small p { height:5px; }"],
template: "..."
})
@ -77,10 +77,10 @@ describe('compiler compliance: styling', () => {
const files = {
app: {
'spec.ts': `
import {Component, NgModule} from '@angular/core';
import {Component, NgModule, ViewEncapsulation} from '@angular/core';
@Component({
encapsulation: ${ViewEncapsulation.Native},
encapsulation: ViewEncapsulation.Native,
selector: "my-component",
styles: ["div.cool { color: blue; }", ":host.nice p { color: gold; }"],
template: "..."