From c5b6e31d97f805833bde9c836f306e7def3fcdd4 Mon Sep 17 00:00:00 2001 From: Igor Minar Date: Wed, 11 Apr 2018 16:01:53 -0700 Subject: [PATCH] build: fix aio size tracking, we need to use node_modules local to aio (#23328) This fixes an issue introduced by 4f0cae067656fa4563417542297c67030d911a36 which removed firebase from the root node_modules. PR Close #23328 --- aio/scripts/payload.sh | 3 +++ scripts/ci/payload-size.sh | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/aio/scripts/payload.sh b/aio/scripts/payload.sh index 189b8022e4..0ab4b73fb9 100755 --- a/aio/scripts/payload.sh +++ b/aio/scripts/payload.sh @@ -8,5 +8,8 @@ readonly parentDir=$(dirname $thisDir) # Track payload size functions source ../scripts/ci/payload-size.sh +# Provide node_modules from aio +NODE_MODULES_BIN=$PROJECT_ROOT/aio/node_modules/.bin/ + trackPayloadSize "aio" "dist/*.js" true true "${thisDir}/_payload-limits.json" diff --git a/scripts/ci/payload-size.sh b/scripts/ci/payload-size.sh index ec242a610c..28dfd7346e 100644 --- a/scripts/ci/payload-size.sh +++ b/scripts/ci/payload-size.sh @@ -3,6 +3,7 @@ set -eu -o pipefail readonly PROJECT_NAME="angular-payload-size" +NODE_MODULES_BIN=$PROJECT_ROOT/node_modules/.bin/ # Calculate the size of target file uncompressed size, gzip7 size, gzip9 size # Write to global variable $payloadData, $filename @@ -88,7 +89,7 @@ uploadData() { # WARNING: FIREBASE_TOKEN should NOT be printed. set +x - $PROJECT_ROOT/node_modules/.bin/firebase database:update --data "$payloadData" --project $PROJECT_NAME --confirm --token "$ANGULAR_PAYLOAD_FIREBASE_TOKEN" $dbPath + $NODE_MODULES_BIN/firebase database:update --data "$payloadData" --project $PROJECT_NAME --confirm --token "$ANGULAR_PAYLOAD_FIREBASE_TOKEN" $dbPath fi }