cargdev/angular
1
0
Fork 0
Code Issues 10 Pull Requests Actions Packages Projects Releases Wiki Activity

chore: kill ListWrapper.create() and .push().

Browse Source 
These wrappers are not natively understood by
ts2dart. Removing them will improve Dart2JS
compilation due to fewer megamorphic calls to List
functions.

It also makes Angular code more succinct and
improves type safety in Angular due to better type
inference of the Array component type.

This change exposed several bugs in Angular.
This commit is contained in:
Martin Probst
2015-06-17 11:17:21 -07:00
parent 6af41a4543
commit c7e48350d3
88 changed files with 360 additions and 387 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
modules/angular2/src/debug/debug_element.ts
View File

@ -69,7 +69,7 @@ export class DebugElement {
if (!isPresent(shadowView)) {
// The current element is not a component.
return ListWrapper.create();
return [];
}
return this._getChildElements(shadowView, null);
@ -123,7 +123,7 @@ export class DebugElement {
}
_getChildElements(view: AppView, parentBoundElementIndex: number): List<DebugElement> {
var els = ListWrapper.create();
var els = [];
var parentElementBinder = null;
if (isPresent(parentBoundElementIndex)) {
parentElementBinder = view.proto.elementBinders[parentBoundElementIndex];
@ -131,7 +131,7 @@ export class DebugElement {
for (var i = 0; i < view.proto.elementBinders.length; ++i) {
var binder = view.proto.elementBinders[i];
if (binder.parent == parentElementBinder) {
ListWrapper.push(els, new DebugElement(view, i));
els.push(new DebugElement(view, i));
var views = view.viewContainers[i];
if (isPresent(views)) {
@ -154,8 +154,8 @@ export function inspectElement(elementRef: ElementRef): DebugElement {
*/
export class Scope {
static all(debugElement): List<DebugElement> {
var scope = ListWrapper.create();
ListWrapper.push(scope, debugElement);
var scope = [];
scope.push(debugElement);
ListWrapper.forEach(debugElement.children,
(child) => { scope = ListWrapper.concat(scope, Scope.all(child)); });
@ -166,19 +166,19 @@ export class Scope {
return scope;
}
static light(debugElement): List<DebugElement> {
var scope = ListWrapper.create();
var scope = [];
ListWrapper.forEach(debugElement.children, (child) => {
ListWrapper.push(scope, child);
scope.push(child);
scope = ListWrapper.concat(scope, Scope.light(child));
});
return scope;
}
static view(debugElement): List<DebugElement> {
var scope = ListWrapper.create();
var scope = [];
ListWrapper.forEach(debugElement.componentViewChildren, (child) => {
ListWrapper.push(scope, child);
scope.push(child);
scope = ListWrapper.concat(scope, Scope.light(child));
});
return scope;