cargdev/angular
1
0
Fork 0
Code Issues 15 Pull Requests Actions Packages Projects Releases Wiki Activity

chore: kill ListWrapper.create() and .push().

Browse Source 
These wrappers are not natively understood by
ts2dart. Removing them will improve Dart2JS
compilation due to fewer megamorphic calls to List
functions.

It also makes Angular code more succinct and
improves type safety in Angular due to better type
inference of the Array component type.

This change exposed several bugs in Angular.
This commit is contained in:
Martin Probst
2015-06-17 11:17:21 -07:00
parent 6af41a4543
commit c7e48350d3
88 changed files with 360 additions and 387 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
modules/angular2/src/http/headers.ts
View File

@ -33,8 +33,8 @@ export class Headers {
this._headersMap = MapWrapper.createFromStringMap(headers);
MapWrapper.forEach(this._headersMap, (v, k) => {
if (!isListLikeIterable(v)) {
var list = ListWrapper.create();
ListWrapper.push(list, v);
var list = [];
list.push(v);
MapWrapper.set(this._headersMap, k, list);
}
});
@ -42,8 +42,8 @@ export class Headers {
}
append(name: string, value: string): void {
var list = MapWrapper.get(this._headersMap, name) || ListWrapper.create();
ListWrapper.push(list, value);
var list = MapWrapper.get(this._headersMap, name) || [];
list.push(value);
MapWrapper.set(this._headersMap, name, list);
}
@ -61,11 +61,11 @@ export class Headers {
// TODO: this implementation seems wrong. create list then check if it's iterable?
set(header: string, value: string | List<string>): void {
var list = ListWrapper.create();
var list = [];
if (!isListLikeIterable(value)) {
ListWrapper.push(list, value);
list.push(value);
} else {
ListWrapper.push(list, ListWrapper.toString((<List<string>>value)));
list.push(ListWrapper.toString((<List<string>>value)));
}
MapWrapper.set(this._headersMap, header, list);
@ -73,9 +73,7 @@ export class Headers {
values() { return MapWrapper.values(this._headersMap); }
getAll(header: string): Array<string> {
return MapWrapper.get(this._headersMap, header) || ListWrapper.create();
}
getAll(header: string): Array<string> { return MapWrapper.get(this._headersMap, header) || []; }
entries() { throw new BaseException('"entries" method is not implemented on Headers class'); }
}

16
modules/angular2/src/http/url_search_params.ts
View File

@ -8,8 +8,8 @@ function paramParser(rawParams: string): Map<string, List<string>> {
var split: List<string> = StringWrapper.split(param, '=');
var key = ListWrapper.get(split, 0);
var val = ListWrapper.get(split, 1);
var list = MapWrapper.get(map, key) || ListWrapper.create();
ListWrapper.push(list, val);
var list = MapWrapper.get(map, key) || [];
list.push(val);
MapWrapper.set(map, key, list);
});
return map;
@ -23,20 +23,18 @@ export class URLSearchParams {
get(param: string): string { return ListWrapper.first(MapWrapper.get(this.paramsMap, param)); }
getAll(param: string): List<string> {
return MapWrapper.get(this.paramsMap, param) || ListWrapper.create();
}
getAll(param: string): List<string> { return MapWrapper.get(this.paramsMap, param) || []; }
append(param: string, val: string): void {
var list = MapWrapper.get(this.paramsMap, param) || ListWrapper.create();
ListWrapper.push(list, val);
var list = MapWrapper.get(this.paramsMap, param) || [];
list.push(val);
MapWrapper.set(this.paramsMap, param, list);
}
toString(): string {
var paramsList = ListWrapper.create();
var paramsList = [];
MapWrapper.forEach(this.paramsMap, (values, k) => {
ListWrapper.forEach(values, v => { ListWrapper.push(paramsList, k + '=' + v); });
ListWrapper.forEach(values, v => { paramsList.push(k + '=' + v); });
});
return ListWrapper.join(paramsList, '&');
}