cargdev/angular
1
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(common): http/testing expectOne lists the received requests if no matches (#27005)

Browse Source 
Fixes #18013

Previously it was hard to debug an `expectOne` if the request had no match, as the error message was:

    Expected one matching request for criteria "Match URL: /some-url?query=hello", found none.

This commit adds a bit more info to the error, by listing the actual requests received:

    Expected one matching request for criteria "Match URL: /some-url?query=hello", found none. Requests received are: POST /some-url?query=world.

PR Close #27005
This commit is contained in:
cexbrayat
2018-11-08 16:25:29 +01:00
committed by Misko Hevery
parent 2172929099
commit c7f0c017ca
2 changed files with 18 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
packages/common/http/testing/test/request_spec.ts
View File

@ -36,7 +36,9 @@ describe('HttpClient TestRequest', () => {
fail();
} catch (error) {
expect(error.message)
.toBe('Expected one matching request for criteria "Match URL: /some-url", found none.');
.toBe(
'Expected one matching request for criteria "Match URL: /some-url", found none.' +
' Requests received are: GET /some-other-url.');
}
});
@ -55,7 +57,8 @@ describe('HttpClient TestRequest', () => {
} catch (error) {
expect(error.message)
.toBe(
'Expected one matching request for criteria "Match URL: /some-url?query=world", found none.');
'Expected one matching request for criteria "Match URL: /some-url?query=world", found none.' +
' Requests received are: GET /some-url?query=hello.');
}
});
});