cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

build(bazel): Turning on strictPropertyInitialization for Angular. (#24572)

Browse Source 
All errors for existing fields have been detected and suppressed with a
`!` assertion.

Issue/24571 is tracking proper clean up of those instances.

One-line change required in ivy/compilation.ts, because it appears that
the new syntax causes tsickle emitted node to no longer track their
original sourceFiles.

PR Close #24572
This commit is contained in:
Rado Kirov
2018-06-18 16:38:33 -07:00
committed by Miško Hevery
parent 39c7769c9e
commit c95437f15d
189 changed files with 1273 additions and 632 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
packages/animations/browser/src/dsl/animation_timeline_builder.ts
View File

@ -586,7 +586,8 @@ export class AnimationTimelineContext {
export class TimelineBuilder {
public duration: number = 0;
public easing: string|null;
// TODO(issue/24571): remove '!'.
public easing !: string | null;
private _previousKeyframe: ɵStyleData = {};
private _currentKeyframe: ɵStyleData = {};
private _keyframes = new Map<number, ɵStyleData>();

6
packages/animations/browser/src/render/css_keyframes/css_keyframes_player.ts
View File

@ -23,9 +23,11 @@ export class CssKeyframesPlayer implements AnimationPlayer {
private _onDestroyFns: Function[] = [];
private _started = false;
private _styler: ElementAnimationStyleHandler;
// TODO(issue/24571): remove '!'.
private _styler !: ElementAnimationStyleHandler;
public parentPlayer: AnimationPlayer;
// TODO(issue/24571): remove '!'.
public parentPlayer !: AnimationPlayer;
public readonly totalTime: number;
public readonly easing: string;
public currentSnapshot: {[key: string]: string} = {};

3
packages/animations/browser/src/render/transition_animation_engine.ts
View File

@ -1424,7 +1424,8 @@ export class TransitionAnimationPlayer implements AnimationPlayer {
private _queuedCallbacks: {[name: string]: (() => any)[]} = {};
public readonly destroyed = false;
public parentPlayer: AnimationPlayer;
// TODO(issue/24571): remove '!'.
public parentPlayer !: AnimationPlayer;
public markedForDestroy: boolean = false;
public disabled = false;

6
packages/animations/browser/src/render/web_animations/web_animations_player.ts
View File

@ -21,9 +21,11 @@ export class WebAnimationsPlayer implements AnimationPlayer {
private _finished = false;
private _started = false;
private _destroyed = false;
private _finalKeyframe: {[key: string]: string | number};
// TODO(issue/24571): remove '!'.
private _finalKeyframe !: {[key: string]: string | number};
public readonly domPlayer: DOMAnimation;
// TODO(issue/24571): remove '!'.
public readonly domPlayer !: DOMAnimation;
public time = 0;
public parentPlayer: AnimationPlayer|null = null;