build(bazel): Turning on strictPropertyInitialization for Angular. (#24572)

All errors for existing fields have been detected and suppressed with a
`!` assertion.

Issue/24571 is tracking proper clean up of those instances.

One-line change required in ivy/compilation.ts, because it appears that
the new syntax causes tsickle emitted node to no longer track their
original sourceFiles.

PR Close #24572
This commit is contained in:
Rado Kirov
2018-06-18 16:38:33 -07:00
committed by Miško Hevery
parent 39c7769c9e
commit c95437f15d
189 changed files with 1273 additions and 632 deletions

View File

@ -20,7 +20,8 @@ export class HttpHeaders {
/**
* Internal map of lowercase header names to values.
*/
private headers: Map<string, string[]>;
// TODO(issue/24571): remove '!'.
private headers !: Map<string, string[]>;
/**
@ -32,7 +33,8 @@ export class HttpHeaders {
/**
* Complete the lazy initialization of this object (needed before reading).
*/
private lazyInit: HttpHeaders|Function|null;
// TODO(issue/24571): remove '!'.
private lazyInit !: HttpHeaders | Function | null;
/**
* Queued updates to be materialized the next initialization.

View File

@ -88,7 +88,8 @@ export class HttpRequest<T> {
/**
* Outgoing headers for this request.
*/
readonly headers: HttpHeaders;
// TODO(issue/24571): remove '!'.
readonly headers !: HttpHeaders;
/**
* Whether this request should be made in a way that exposes progress events.
@ -119,7 +120,8 @@ export class HttpRequest<T> {
/**
* Outgoing URL parameters.
*/
readonly params: HttpParams;
// TODO(issue/24571): remove '!'.
readonly params !: HttpParams;
/**
* The outgoing URL with all URL parameters set.

View File

@ -171,7 +171,8 @@ export abstract class HttpResponseBase {
/**
* Type of the response, narrowed to either the full response or the header.
*/
readonly type: HttpEventType.Response|HttpEventType.ResponseHeader;
// TODO(issue/24571): remove '!'.
readonly type !: HttpEventType.Response | HttpEventType.ResponseHeader;
/**
* Super-constructor for all responses.

View File

@ -22,7 +22,8 @@ export class MockScriptElement {
}
export class MockDocument {
mock: MockScriptElement|null;
// TODO(issue/24571): remove '!'.
mock !: MockScriptElement | null;
readonly body: any = this;
createElement(tag: 'script'): HTMLScriptElement {

View File

@ -10,7 +10,8 @@ import {HttpHeaders} from '../src/headers';
import {XhrFactory} from '../src/xhr';
export class MockXhrFactory implements XhrFactory {
mock: MockXMLHttpRequest;
// TODO(issue/24571): remove '!'.
mock !: MockXMLHttpRequest;
build(): XMLHttpRequest { return (this.mock = new MockXMLHttpRequest()) as any; }
}
@ -30,8 +31,10 @@ export class MockXMLHttpRequestUpload {
export class MockXMLHttpRequest {
// Set by method calls.
body: any;
method: string;
url: string;
// TODO(issue/24571): remove '!'.
method !: string;
// TODO(issue/24571): remove '!'.
url !: string;
mockHeaders: {[key: string]: string} = {};
mockAborted: boolean = false;