cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

build(bazel): Turning on strictPropertyInitialization for Angular. (#24572)

Browse Source 
All errors for existing fields have been detected and suppressed with a
`!` assertion.

Issue/24571 is tracking proper clean up of those instances.

One-line change required in ivy/compilation.ts, because it appears that
the new syntax causes tsickle emitted node to no longer track their
original sourceFiles.

PR Close #24572
This commit is contained in:
Rado Kirov
2018-06-18 16:38:33 -07:00
committed by Miško Hevery
parent 39c7769c9e
commit c95437f15d
189 changed files with 1273 additions and 632 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/compiler/test/expression_parser/utils/unparser.ts
View File

@ -11,8 +11,10 @@ import {DEFAULT_INTERPOLATION_CONFIG, InterpolationConfig} from '../../../src/ml
class Unparser implements AstVisitor {
private static _quoteRegExp = /"/g;
private _expression: string;
private _interpolationConfig: InterpolationConfig;
// TODO(issue/24571): remove '!'.
private _expression !: string;
// TODO(issue/24571): remove '!'.
private _interpolationConfig !: InterpolationConfig;
unparse(ast: AST, interpolationConfig: InterpolationConfig) {
this._expression = '';

9
packages/compiler/test/i18n/integration_common.ts
View File

@ -19,9 +19,12 @@ import {expect} from '@angular/platform-browser/testing/src/matchers';
template: '',
})
export class I18nComponent {
count: number;
sex: string;
sexB: string;
// TODO(issue/24571): remove '!'.
count !: number;
// TODO(issue/24571): remove '!'.
sex !: string;
// TODO(issue/24571): remove '!'.
sexB !: string;
response: any = {getItemsList: (): any[] => []};
}

3
packages/compiler/test/integration_spec.ts
View File

@ -20,7 +20,8 @@ import {expect} from '@angular/platform-browser/testing/src/matchers';
it('should support dotted selectors', async(() => {
@Directive({selector: '[dot.name]'})
class MyDir {
@Input('dot.name') value: string;
// TODO(issue/24571): remove '!'.
@Input('dot.name') value !: string;
}
TestBed.configureTestingModule({