cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test(docs-infra): fix and enable remaining component-interaction e2e tests (#39001)

Browse Source 
Previously, some of the e2e tests of the `component-interaction` docs
example were disabled because they were failing.

This commit fixes and re-enables them.

PR Close #39001
This commit is contained in:
George Kalpakas 2020-09-25 19:17:49 +03:00 committed by Alex Rickabaugh
parent 3fad0ffb3a
commit c95fabf96d
1 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
aio/content/examples/component-interaction/e2e/src/app.e2e-spec.ts
View File

@ -145,19 +145,25 @@ describe('Component Communication Cookbook Tests', () => {
// #enddocregion child-to-parent // #enddocregion child-to-parent
}); });
// Can't run timer tests in protractor because describe('Parent calls child via local var', () => {
// interaction w/ zones causes all tests to freeze & timeout.
xdescribe('Parent calls child via local var', () => {
countDownTimerTests('app-countdown-parent-lv'); countDownTimerTests('app-countdown-parent-lv');
}); });
xdescribe('Parent calls ViewChild', () => { describe('Parent calls ViewChild', () => {
countDownTimerTests('app-countdown-parent-vc'); countDownTimerTests('app-countdown-parent-vc');
}); });
function countDownTimerTests(parentTag: string) { function countDownTimerTests(parentTag: string) {
// #docregion countdown-timer-tests // #docregion countdown-timer-tests
// ... // ...
// The tests trigger periodic asynchronous operations (via `setInterval()`), which will prevent
// the app from stabilizing. See https://angular.io/api/core/ApplicationRef#is-stable-examples
// for more details.
// To allow the tests to complete, we will disable automatically waiting for the Angular app to
// stabilize.
beforeEach(() => browser.waitForAngularEnabled(false));
afterEach(() => browser.waitForAngularEnabled(true));
it('timer and parent seconds should match', async () => { it('timer and parent seconds should match', async () => {
const parent = element(by.tagName(parentTag)); const parent = element(by.tagName(parentTag));
const startButton = parent.element(by.buttonText('Start')); const startButton = parent.element(by.buttonText('Start'));
@ -165,7 +171,9 @@ describe('Component Communication Cookbook Tests', () => {
const timer = parent.element(by.tagName('app-countdown-timer')); const timer = parent.element(by.tagName('app-countdown-timer'));
await startButton.click(); await startButton.click();
await browser.sleep(10); // give `seconds` a chance to catchup with `timer`
// Wait for `<app-countdown-timer>` to be populated with any text.
await browser.wait(() => timer.getText(), 2000);
expect(await timer.getText()).toContain(await seconds.getText()); expect(await timer.getText()).toContain(await seconds.getText());
}); });