From c96dea27ce13399a1ef2342460b1f72cf401d576 Mon Sep 17 00:00:00 2001 From: Pawel Kozlowski Date: Fri, 30 Nov 2018 17:39:17 +0100 Subject: [PATCH] test(ivy): turn ivy test selectors into real functions (#27372) Having real functions allows me to bypass individual checks, ex.: ``` export function fixmeIvy(reason: string): boolean { return true; } ``` This is useful for situation where I want to see if previously disabled tests were fixed (ex. some PRs merged). In this case I don't want to run tests that I know are not passing (obsolete / modified). PR Close #27372 --- packages/private/testing/src/ivy_test_selectors.ts | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/packages/private/testing/src/ivy_test_selectors.ts b/packages/private/testing/src/ivy_test_selectors.ts index dc39e42f52..622d6cf589 100644 --- a/packages/private/testing/src/ivy_test_selectors.ts +++ b/packages/private/testing/src/ivy_test_selectors.ts @@ -63,8 +63,9 @@ export function fixmeIvy(reason: string): boolean { * obsoleteInIvy('some reason') && it(...); * ``` */ -export const obsoleteInIvy = fixmeIvy; - +export function obsoleteInIvy(reason: string): boolean { + return !ivyEnabled; +} /** * A function to conditionally skip the execution of tests that have intentionally @@ -83,4 +84,6 @@ export const obsoleteInIvy = fixmeIvy; * modifiedInIvy('some reason') && it(...); * ``` */ -export const modifiedInIvy = fixmeIvy; +export function modifiedInIvy(reason: string): boolean { + return !ivyEnabled; +} \ No newline at end of file