cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(compiler): handle undefined annotation metadata (#23349)

Browse Source 
In certain cases seen in production, simplify() can returned
undefined when simplifying decorator metadata. This has proven tricky
to reproduce in an isolated test, but the fix is simple and low-risk:
don't attempt to spread an undefined set of annotations in the first
place.

PR Close #23349
This commit is contained in:
Alex Rickabaugh 2018-04-12 14:57:56 -07:00 committed by Victor Berchet
parent f2563ca800
commit ca776c59dd
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/compiler/src/aot/static_reflector.ts
View File

@ -163,8 +163,10 @@ export class StaticReflector implements CompileReflector {
let ownAnnotations: any[] = []; let ownAnnotations: any[] = [];
if (classMetadata['decorators']) { if (classMetadata['decorators']) {
ownAnnotations = simplify(type, classMetadata['decorators']); ownAnnotations = simplify(type, classMetadata['decorators']);
if (ownAnnotations) {
annotations.push(...ownAnnotations); annotations.push(...ownAnnotations);
} }
}
if (parentType && !this.summaryResolver.isLibraryFile(type.filePath) && if (parentType && !this.summaryResolver.isLibraryFile(type.filePath) &&
this.summaryResolver.isLibraryFile(parentType.filePath)) { this.summaryResolver.isLibraryFile(parentType.filePath)) {
const summary = this.summaryResolver.resolveSummary(parentType); const summary = this.summaryResolver.resolveSummary(parentType);