cargdev/angular
1
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(core): remove testing-only node getters and invoke() from DomAdapters (#32291)

Browse Source 
PR Close #32291
This commit is contained in:
Kara Erickson
2019-08-24 08:18:00 -07:00
committed by Miško Hevery
parent c0680602f9
commit cb5701f8d9
6 changed files with 11 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
packages/core/test/linker/integration_spec.ts
View File

@ -1494,8 +1494,7 @@ function declareTests(config?: {useJit: boolean}) {
expect(noSelectorComponentFactory.selector).toBe('ng-component');
expect(
getDOM()
.nodeName(noSelectorComponentFactory.create(Injector.NULL).location.nativeElement)
noSelectorComponentFactory.create(Injector.NULL).location.nativeElement.nodeName
.toLowerCase())
.toEqual('ng-component');
});
@ -1534,7 +1533,7 @@ function declareTests(config?: {useJit: boolean}) {
throw 'Should throw';
} catch (e) {
const c = getDebugContext(e);
expect(getDOM().nodeName(c.componentRenderElement).toUpperCase()).toEqual('DIV');
expect(c.componentRenderElement.nodeName.toUpperCase()).toEqual('DIV');
expect((<Injector>c.injector).get).toBeTruthy();
}
});
@ -1550,8 +1549,8 @@ function declareTests(config?: {useJit: boolean}) {
throw 'Should throw';
} catch (e) {
const c = getDebugContext(e);
expect(getDOM().nodeName(c.renderNode).toUpperCase()).toEqual('INPUT');
expect(getDOM().nodeName(c.componentRenderElement).toUpperCase()).toEqual('DIV');
expect(c.renderNode.nodeName.toUpperCase()).toEqual('INPUT');
expect(c.componentRenderElement.nodeName.toUpperCase()).toEqual('DIV');
expect((<Injector>c.injector).get).toBeTruthy();
expect(c.context).toEqual(fixture.componentInstance);
expect(c.references['local']).toBeDefined();
@ -1595,8 +1594,8 @@ function declareTests(config?: {useJit: boolean}) {
expect(err).toBeTruthy();
const c = getDebugContext(err);
expect(getDOM().nodeName(c.renderNode).toUpperCase()).toEqual('SPAN');
expect(getDOM().nodeName(c.componentRenderElement).toUpperCase()).toEqual('DIV');
expect(c.renderNode.nodeName.toUpperCase()).toEqual('SPAN');
expect(c.componentRenderElement.nodeName.toUpperCase()).toEqual('DIV');
expect((<Injector>c.injector).get).toBeTruthy();
expect(c.context).toEqual(fixture.componentInstance);
expect(c.references['local']).toBeDefined();

2
packages/core/test/view/component_view_spec.ts
View File

@ -43,7 +43,7 @@ const addEventListener = '__zone_symbol__addEventListener' as 'addEventListener'
expect(compView.component).toBe(instance);
const compRootEl = rootNodes[0].childNodes[0];
expect(getDOM().nodeName(compRootEl).toLowerCase()).toBe('span');
expect(compRootEl.nodeName.toLowerCase()).toBe('span');
});
if (isBrowser()) {

4
packages/core/test/view/element_spec.ts
View File

@ -32,7 +32,7 @@ const removeEventListener = '__zone_symbol__removeEventListener' as 'removeEvent
elementDef(0, NodeFlags.None, null, null, 0, 'span')
])).rootNodes;
expect(rootNodes.length).toBe(1);
expect(getDOM().nodeName(rootNodes[0]).toLowerCase()).toBe('span');
expect(rootNodes[0].nodeName.toLowerCase()).toBe('span');
});
it('should create views with multiple root elements', () => {
@ -50,7 +50,7 @@ const removeEventListener = '__zone_symbol__removeEventListener' as 'removeEvent
])).rootNodes;
expect(rootNodes.length).toBe(1);
const spanEl = rootNodes[0].childNodes[0];
expect(getDOM().nodeName(spanEl).toLowerCase()).toBe('span');
expect(spanEl.nodeName.toLowerCase()).toBe('span');
});
it('should set fixed attributes', () => {