cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ivy): ComponentFactory.create should clear host element content (#33487)

Browse Source 
Prior to this change, ComponentFactory.create function invocation in Ivy retained the content of the host element (in case host element reference or CSS seelctor is provided as an argument). This behavior is different in View Engine, where the content of the host element was cleared, except for the case when ShadowDom encapsulation is used (to make sure native slot projection works). This commit aligns Ivy and View Engine and makes sure the host element is cleared before component content insertion.

PR Close #33487
This commit is contained in:
Andrew Kushnir
2019-10-28 23:40:16 -07:00
committed by Kara Erickson
parent 9485e16e3b
commit cf10b336e7
8 changed files with 139 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
packages/core/src/compiler/compiler_facade_interface.ts
View File

@ -167,7 +167,12 @@ export interface R3FactoryDefMetadataFacade {
target: R3FactoryTarget;
}
export type ViewEncapsulation = number;
export enum ViewEncapsulation {
Emulated = 0,
Native = 1,
None = 2,
ShadowDom = 3
}
export type ChangeDetectionStrategy = number;