cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs(core): tidy up the description of resolveComponentResources() (#28055) (#28736)

Browse Source 
There were a number of typos and some of the sentences did not
read well.

PR Close #28055

PR Close #28736
This commit is contained in:
Pete Bacon Darwin 2019-02-08 22:10:19 +00:00 committed by Andrew Kushnir
parent ee6498f37e
commit cf916a03d3
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
packages/core/src/metadata/resource_loading.ts
View File

@ -18,18 +18,18 @@ import {Component} from './directives';
* selector: 'my-comp', * selector: 'my-comp',
* templateUrl: 'my-comp.html', // This requires asynchronous resolution * templateUrl: 'my-comp.html', // This requires asynchronous resolution
* }) * })
* class MyComponnent{ * class MyComponent{
* } * }
* *
* // Calling `renderComponent` will fail because `MyComponent`'s `@Compenent.templateUrl` * // Calling `renderComponent` will fail because `renderComponent` is a synchronous process
* // needs to be resolved because `renderComponent` is synchronous process. * // and `MyComponent`'s `@Component.templateUrl` needs to be resolved asynchronously.
* // renderComponent(MyComponent);
* *
* // Calling `resolveComponentResources` will resolve `@Compenent.templateUrl` into * // Calling `resolveComponentResources()` will resolve `@Component.templateUrl` into
* // `@Compenent.template`, which would allow `renderComponent` to proceed in synchronous manner. * // `@Component.template`, which allows `renderComponent` to proceed in a synchronous manner.
* // Use browser's `fetch` function as the default resource resolution strategy. *
* // Use browser's `fetch()` function as the default resource resolution strategy.
* resolveComponentResources(fetch).then(() => { * resolveComponentResources(fetch).then(() => {
* // After resolution all URLs have been converted into strings. * // After resolution all URLs have been converted into `template` strings.
* renderComponent(MyComponent); * renderComponent(MyComponent);
* }); * });
* *
@ -38,8 +38,8 @@ import {Component} from './directives';
* NOTE: In AOT the resolution happens during compilation, and so there should be no need * NOTE: In AOT the resolution happens during compilation, and so there should be no need
* to call this method outside JIT mode. * to call this method outside JIT mode.
* *
* @param resourceResolver a function which is responsible to returning a `Promise` of the resolved * @param resourceResolver a function which is responsible for returning a `Promise` to the
* URL. Browser's `fetch` method is a good default implementation. * contents of the resolved URL. Browser's `fetch()` method is a good default implementation.
*/ */
export function resolveComponentResources( export function resolveComponentResources(
resourceResolver: (url: string) => (Promise<string|{text(): Promise<string>}>)): Promise<null> { resourceResolver: (url: string) => (Promise<string|{text(): Promise<string>}>)): Promise<null> {