From cffa0fe734085084760146afe38b2f2be055b11b Mon Sep 17 00:00:00 2001 From: Chuck Jazdzewski Date: Wed, 10 Jan 2018 16:18:26 -0800 Subject: [PATCH] feat(bazel): allow ng_module rules to control whether type checking is enabled (#21460) Defaults to true which is different than `ngc` which defaults to false. PR Close #21460 --- packages/bazel/src/ng_module.bzl | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/bazel/src/ng_module.bzl b/packages/bazel/src/ng_module.bzl index 11042e0ace..e88a6c7028 100644 --- a/packages/bazel/src/ng_module.bzl +++ b/packages/bazel/src/ng_module.bzl @@ -74,6 +74,7 @@ def _ngc_tsconfig(ctx, files, srcs, **kwargs): "generateCodeForLibraries": False, "allowEmptyCodegenFiles": True, "enableSummariesForJit": True, + "fullTemplateTypeCheck": ctx.attr.type_check, # FIXME: wrong place to de-dupe "expectedOut": depset([o.path for o in expected_outs]).to_list(), "preserveWhitespaces": False, @@ -262,6 +263,8 @@ NG_MODULE_ATTRIBUTES = { ".html", ]), + "type_check": attr.bool(default = True), + "no_i18n": attr.bool(default = False), "compiler": attr.label(