cargdev/angular
1
0
Fork 0
Code Issues 10 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(dev-infra): Add support for groups in the conditions evaluator (#38164)

Browse Source 
Conditions can refer to the groups array that is a list of the preceding groups.
This commit adds support to the verification for those conditions.

This commit also adds some tests to the parsing and condition matching
to ensure everything works as expected.

PR Close #38164
This commit is contained in:
Andrew Scott
2020-07-20 11:53:26 -07:00
committed by Misko Hevery
parent 7b2e2f5d91
commit d0060dcfdc
9 changed files with 280 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
dev-infra/pullapprove/verify.ts
View File

@ -11,10 +11,8 @@ import {resolve} from 'path';
import {getRepoBaseDir} from '../utils/config';
import {debug, info} from '../utils/console';
import {allFiles} from '../utils/repo-files';
import {PullApproveGroup} from './group';
import {logGroup, logHeader} from './logging';
import {parsePullApproveYaml} from './parse-yaml';
import {getGroupsFromYaml} from './parse-yaml';
export function verify() {
/** Full path to PullApprove config file */
@ -23,12 +21,8 @@ export function verify() {
const REPO_FILES = allFiles();
/** The pull approve config file. */
const pullApproveYamlRaw = readFileSync(PULL_APPROVE_YAML_PATH, 'utf8');
/** JSON representation of the pullapprove yaml file. */
const pullApprove = parsePullApproveYaml(pullApproveYamlRaw);
/** All of the groups defined in the pullapprove yaml. */
const groups = Object.entries(pullApprove.groups).map(([groupName, group]) => {
return new PullApproveGroup(groupName, group);
});
const groups = getGroupsFromYaml(pullApproveYamlRaw);
/**
* PullApprove groups without conditions. These are skipped in the verification
* as those would always be active and cause zero unmatched files.