refactor(compiler): remove unused code
BREAKING CHANGE: - Removes `ChangeDetection`, use a binding for `ChangeDetectorGenConfig` instead to configure change detection. - `RenderElementRef.renderBoundElementIndex` was renamed to `RenderElementRef.boundElementIndex`. - Removes `ViewLoader`, use `XHRImpl` instead.
This commit is contained in:
Tobias Bosch
@ -1,77 +0,0 @@
|
||||
library angular2.transform.common.convert;
|
||||
|
||||
import "package:angular2/src/core/facade/collection.dart"
|
||||
show ListWrapper, MapWrapper;
|
||||
import "package:angular2/src/core/facade/lang.dart" show isPresent, isArray;
|
||||
import "package:angular2/src/core/render/api.dart" show RenderDirectiveMetadata;
|
||||
import "package:angular2/src/core/change_detection/change_detection.dart"
|
||||
show ChangeDetectionStrategy;
|
||||
|
||||
/**
|
||||
* Converts a [DirectiveMetadata] to a map representation. This creates a copy,
|
||||
* that is, subsequent changes to `meta` will not be mirrored in the map.
|
||||
*/
|
||||
Map<String, dynamic> directiveMetadataToMap(RenderDirectiveMetadata meta) {
|
||||
return MapWrapper.createFromPairs([
|
||||
["id", meta.id],
|
||||
["selector", meta.selector],
|
||||
["compileChildren", meta.compileChildren],
|
||||
["hostProperties", _cloneIfPresent(meta.hostProperties)],
|
||||
["hostListeners", _cloneIfPresent(meta.hostListeners)],
|
||||
["hostAttributes", _cloneIfPresent(meta.hostAttributes)],
|
||||
["inputs", _cloneIfPresent(meta.inputs)],
|
||||
["readAttributes", _cloneIfPresent(meta.readAttributes)],
|
||||
["type", meta.type],
|
||||
["exportAs", meta.exportAs],
|
||||
["callOnDestroy", meta.callOnDestroy],
|
||||
["callDoCheck", meta.callDoCheck],
|
||||
["callOnInit", meta.callOnInit],
|
||||
["callOnChanges", meta.callOnChanges],
|
||||
["callAfterContentInit", meta.callAfterContentInit],
|
||||
["callAfterContentChecked", meta.callAfterContentChecked],
|
||||
["callAfterViewInit", meta.callAfterViewInit],
|
||||
["callAfterViewChecked", meta.callAfterViewChecked],
|
||||
["outputs", meta.outputs],
|
||||
["changeDetection", meta.changeDetection == null ? null : meta.changeDetection.index],
|
||||
["version", 1]
|
||||
]);
|
||||
}
|
||||
/**
|
||||
* Converts a map representation of [DirectiveMetadata] into a
|
||||
* [DirectiveMetadata] object. This creates a copy, that is, subsequent changes
|
||||
* to `map` will not be mirrored in the [DirectiveMetadata] object.
|
||||
*/
|
||||
RenderDirectiveMetadata directiveMetadataFromMap(Map<String, dynamic> map) {
|
||||
return new RenderDirectiveMetadata(
|
||||
id: (map["id"] as String),
|
||||
selector: (map["selector"] as String),
|
||||
compileChildren: (map["compileChildren"] as bool),
|
||||
hostProperties: (_cloneIfPresent(
|
||||
map["hostProperties"]) as Map<String, String>),
|
||||
hostListeners: (_cloneIfPresent(
|
||||
map["hostListeners"]) as Map<String, String>),
|
||||
hostAttributes: (_cloneIfPresent(
|
||||
map["hostAttributes"]) as Map<String, String>),
|
||||
inputs: (_cloneIfPresent(map["inputs"]) as List<String>),
|
||||
readAttributes: (_cloneIfPresent(map["readAttributes"]) as List<String>),
|
||||
type: (map["type"] as num),
|
||||
exportAs: (map["exportAs"] as String),
|
||||
callOnDestroy: (map["callOnDestroy"] as bool),
|
||||
callDoCheck: (map["callDoCheck"] as bool),
|
||||
callOnChanges: (map["callOnChanges"] as bool),
|
||||
callOnInit: (map["callOnInit"] as bool),
|
||||
callAfterContentInit: (map["callAfterContentInit"] as bool),
|
||||
callAfterContentChecked: (map["callAfterContentChecked"] as bool),
|
||||
callAfterViewInit: (map["callAfterViewInit"] as bool),
|
||||
callAfterViewChecked: (map["callAfterViewChecked"] as bool),
|
||||
outputs: (_cloneIfPresent(map["outputs"]) as List<String>),
|
||||
changeDetection: map["changeDetection"] == null ? null
|
||||
: ChangeDetectionStrategy.values[map["changeDetection"] as int]);
|
||||
}
|
||||
/**
|
||||
* Clones the [List] or [Map] `o` if it is present.
|
||||
*/
|
||||
dynamic _cloneIfPresent(o) {
|
||||
if (!isPresent(o)) return null;
|
||||
return isArray(o) ? ListWrapper.clone(o) : MapWrapper.clone(o);
|
||||
}
|
||||
@ -1,7 +1,6 @@
|
||||
library angular2.transform.common.registered_type;
|
||||
|
||||
import 'package:analyzer/analyzer.dart';
|
||||
import 'package:angular2/src/core/render/api.dart';
|
||||
import 'package:angular2/src/transform/common/names.dart';
|
||||
|
||||
/// A call to `Reflector#registerType` generated by `DirectiveProcessor`.
|
||||
@ -44,8 +43,6 @@ class RegisteredType {
|
||||
return new RegisteredType._(visitor.typeName, registerMethod, visitor.info,
|
||||
visitor.factoryFn, visitor.parameters, visitor.annotations, visitor.propMetadata);
|
||||
}
|
||||
|
||||
RenderDirectiveMetadata get directiveMetadata => null;
|
||||
}
|
||||
|
||||
class _ParseRegisterTypeVisitor extends Object
|
||||
|
||||
@ -6,7 +6,6 @@ import 'dart:convert';
|
||||
import 'package:analyzer/analyzer.dart';
|
||||
import 'package:angular2/src/compiler/directive_metadata.dart';
|
||||
import 'package:angular2/src/compiler/template_compiler.dart';
|
||||
import 'package:angular2/src/core/render/api.dart';
|
||||
import 'package:angular2/src/transform/common/asset_reader.dart';
|
||||
import 'package:angular2/src/transform/common/logging.dart';
|
||||
import 'package:angular2/src/transform/common/names.dart';
|
||||
|
||||
@ -1,146 +0,0 @@
|
||||
library angular2.test.transform.common.convert_spec;
|
||||
|
||||
import "package:angular2/src/core/facade/collection.dart" show MapWrapper;
|
||||
import "package:angular2/src/core/render/api.dart" show RenderDirectiveMetadata;
|
||||
import "package:angular2/src/transform/common/convert.dart"
|
||||
show directiveMetadataFromMap, directiveMetadataToMap;
|
||||
import "package:angular2/test_lib.dart" show ddescribe, describe, expect, it;
|
||||
import "package:angular2/src/core/change_detection/change_detection.dart"
|
||||
show ChangeDetectionStrategy;
|
||||
|
||||
main() {
|
||||
describe("convert", () {
|
||||
it("directiveMetadataToMap", () {
|
||||
var someComponent = new RenderDirectiveMetadata(
|
||||
compileChildren: false,
|
||||
hostListeners: MapWrapper.createFromPairs([
|
||||
["LKey", "LVal"]
|
||||
]),
|
||||
hostProperties: MapWrapper.createFromPairs([
|
||||
["PKey", "PVal"]
|
||||
]),
|
||||
hostAttributes: MapWrapper.createFromPairs([
|
||||
["AtKey", "AtVal"]
|
||||
]),
|
||||
id: "someComponent",
|
||||
inputs: ["propKey: propVal"],
|
||||
readAttributes: ["read1", "read2"],
|
||||
selector: "some-comp",
|
||||
type: RenderDirectiveMetadata.COMPONENT_TYPE,
|
||||
exportAs: "aaa",
|
||||
callOnDestroy: true,
|
||||
callOnChanges: true,
|
||||
callDoCheck: true,
|
||||
callOnInit: true,
|
||||
callAfterContentInit: true,
|
||||
callAfterContentChecked: true,
|
||||
callAfterViewInit: true,
|
||||
callAfterViewChecked: true,
|
||||
outputs: ["onFoo", "onBar"],
|
||||
changeDetection: ChangeDetectionStrategy.CheckOnce);
|
||||
var map = directiveMetadataToMap(someComponent);
|
||||
expect(map["compileChildren"]).toEqual(false);
|
||||
expect(map["hostListeners"]).toEqual(MapWrapper.createFromPairs([
|
||||
["LKey", "LVal"]
|
||||
]));
|
||||
expect(map["hostProperties"]).toEqual(MapWrapper.createFromPairs([
|
||||
["PKey", "PVal"]
|
||||
]));
|
||||
expect(map["hostAttributes"]).toEqual(MapWrapper.createFromPairs([
|
||||
["AtKey", "AtVal"]
|
||||
]));
|
||||
expect(map["id"]).toEqual("someComponent");
|
||||
expect(map["inputs"]).toEqual(["propKey: propVal"]);
|
||||
expect(map["readAttributes"]).toEqual(["read1", "read2"]);
|
||||
expect(map["selector"]).toEqual("some-comp");
|
||||
expect(map["type"]).toEqual(RenderDirectiveMetadata.COMPONENT_TYPE);
|
||||
expect(map["callOnDestroy"]).toEqual(true);
|
||||
expect(map["callDoCheck"]).toEqual(true);
|
||||
expect(map["callOnChanges"]).toEqual(true);
|
||||
expect(map["callOnInit"]).toEqual(true);
|
||||
expect(map["callAfterContentInit"]).toEqual(true);
|
||||
expect(map["callAfterContentChecked"]).toEqual(true);
|
||||
expect(map["callAfterViewInit"]).toEqual(true);
|
||||
expect(map["callAfterViewChecked"]).toEqual(true);
|
||||
expect(map["exportAs"]).toEqual("aaa");
|
||||
expect(map["outputs"]).toEqual(["onFoo", "onBar"]);
|
||||
expect(map["changeDetection"])
|
||||
.toEqual(ChangeDetectionStrategy.CheckOnce.index);
|
||||
});
|
||||
it("mapToDirectiveMetadata", () {
|
||||
var map = MapWrapper.createFromPairs([
|
||||
["compileChildren", false],
|
||||
[
|
||||
"hostProperties",
|
||||
MapWrapper.createFromPairs([
|
||||
["PKey", "testVal"]
|
||||
])
|
||||
],
|
||||
[
|
||||
"hostListeners",
|
||||
MapWrapper.createFromPairs([
|
||||
["LKey", "testVal"]
|
||||
])
|
||||
],
|
||||
[
|
||||
"hostAttributes",
|
||||
MapWrapper.createFromPairs([
|
||||
["AtKey", "testVal"]
|
||||
])
|
||||
],
|
||||
["id", "testId"],
|
||||
[
|
||||
"inputs",
|
||||
["propKey: propVal"]
|
||||
],
|
||||
[
|
||||
"readAttributes",
|
||||
["readTest1", "readTest2"]
|
||||
],
|
||||
["selector", "testSelector"],
|
||||
["type", RenderDirectiveMetadata.DIRECTIVE_TYPE],
|
||||
["exportAs", "aaa"],
|
||||
["callOnDestroy", true],
|
||||
["callDoCheck", true],
|
||||
["callOnInit", true],
|
||||
["callOnChanges", true],
|
||||
["callAfterContentInit", true],
|
||||
["callAfterContentChecked", true],
|
||||
["callAfterViewInit", true],
|
||||
["callAfterViewChecked", true],
|
||||
[
|
||||
"outputs",
|
||||
["onFoo", "onBar"]
|
||||
],
|
||||
["changeDetection", ChangeDetectionStrategy.CheckOnce.index]
|
||||
]);
|
||||
var meta = directiveMetadataFromMap(map);
|
||||
expect(meta.compileChildren).toEqual(false);
|
||||
expect(meta.hostProperties).toEqual(MapWrapper.createFromPairs([
|
||||
["PKey", "testVal"]
|
||||
]));
|
||||
expect(meta.hostListeners).toEqual(MapWrapper.createFromPairs([
|
||||
["LKey", "testVal"]
|
||||
]));
|
||||
expect(meta.hostAttributes).toEqual(MapWrapper.createFromPairs([
|
||||
["AtKey", "testVal"]
|
||||
]));
|
||||
expect(meta.id).toEqual("testId");
|
||||
expect(meta.inputs).toEqual(["propKey: propVal"]);
|
||||
expect(meta.readAttributes).toEqual(["readTest1", "readTest2"]);
|
||||
expect(meta.selector).toEqual("testSelector");
|
||||
expect(meta.type).toEqual(RenderDirectiveMetadata.DIRECTIVE_TYPE);
|
||||
expect(meta.exportAs).toEqual("aaa");
|
||||
expect(meta.callOnDestroy).toEqual(true);
|
||||
expect(meta.callDoCheck).toEqual(true);
|
||||
expect(meta.callOnInit).toEqual(true);
|
||||
expect(meta.callOnChanges).toEqual(true);
|
||||
expect(meta.callAfterContentInit).toEqual(true);
|
||||
expect(meta.callAfterContentChecked).toEqual(true);
|
||||
expect(meta.callAfterViewInit).toEqual(true);
|
||||
expect(meta.callAfterViewChecked).toEqual(true);
|
||||
expect(meta.outputs).toEqual(["onFoo", "onBar"]);
|
||||
expect(meta.changeDetection).toEqual(ChangeDetectionStrategy.CheckOnce);
|
||||
});
|
||||
});
|
||||
}
|
||||
@ -3,7 +3,6 @@ library angular2.test.transform.directive_metadata_linker.all_tests;
|
||||
import 'dart:async';
|
||||
import 'package:angular2/src/core/render/api.dart';
|
||||
import 'package:angular2/src/core/change_detection/change_detection.dart';
|
||||
import 'package:angular2/src/transform/common/convert.dart';
|
||||
import 'package:angular2/src/transform/common/directive_metadata_reader.dart';
|
||||
import 'package:angular2/src/transform/common/logging.dart';
|
||||
import 'package:angular2/src/transform/common/ng_deps.dart';
|
||||
|
||||
Reference in New Issue
Block a user