cargdev/angular
1
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(injector): change toFactory to use reflector to construct dependencies

Browse Source
This commit is contained in:
vsavkin
2014-10-09 11:35:13 -04:00
parent 06a221671c
commit d313cac42f
6 changed files with 61 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
modules/di/test/di/async_spec.js
View File

@ -30,7 +30,7 @@ export function main() {
describe("asyncGet", function () {
it('should return a future', function () {
var injector = new Injector([
bind(UserList).toAsyncFactory([], fetchUsers)
bind(UserList).toAsyncFactory(fetchUsers)
]);
var p = injector.asyncGet(UserList);
expect(p).toBeFuture();
@ -64,7 +64,7 @@ export function main() {
it('should return a future when instantiating a sync binding ' +
'with an async dependency', function (done) {
var injector = new Injector([
bind(UserList).toAsyncFactory([], fetchUsers),
bind(UserList).toAsyncFactory(fetchUsers),
UserController
]);
@ -77,7 +77,7 @@ export function main() {
it("should create only one instance (async + async)", function (done) {
var injector = new Injector([
bind(UserList).toAsyncFactory([], fetchUsers)
bind(UserList).toAsyncFactory(fetchUsers)
]);
var ul1 = injector.asyncGet(UserList);
@ -109,7 +109,7 @@ export function main() {
it('should show the full path when error happens in a constructor', function (done) {
var injector = new Injector([
UserController,
bind(UserList).toAsyncFactory([], function () {
bind(UserList).toAsyncFactory(function () {
throw "Broken UserList";
})
]);
@ -125,7 +125,7 @@ export function main() {
describe("get", function () {
it('should throw when instantiating an async binding', function () {
var injector = new Injector([
bind(UserList).toAsyncFactory([], fetchUsers)
bind(UserList).toAsyncFactory(fetchUsers)
]);
expect(() => injector.get(UserList))
@ -134,7 +134,7 @@ export function main() {
it('should throw when instantiating a sync binding with an dependency', function () {
var injector = new Injector([
bind(UserList).toAsyncFactory([], fetchUsers),
bind(UserList).toAsyncFactory(fetchUsers),
UserController
]);
@ -144,7 +144,7 @@ export function main() {
it('should resolve synchronously when an async dependency requested as a future', function () {
var injector = new Injector([
bind(UserList).toAsyncFactory([], fetchUsers),
bind(UserList).toAsyncFactory(fetchUsers),
AsyncUserController
]);
var controller = injector.get(AsyncUserController);
@ -155,7 +155,7 @@ export function main() {
it('should wrap sync dependencies into futures if required', function () {
var injector = new Injector([
bind(UserList).toFactory([], () => new UserList()),
bind(UserList).toFactory(() => new UserList()),
AsyncUserController
]);
var controller = injector.get(AsyncUserController);

19
modules/di/test/di/injector_spec.js
View File

@ -108,9 +108,24 @@ export function main() {
});
it('should bind to a factory', function () {
function sportsCarFactory(e:Engine) {
return new SportsCar(e);
}
var injector = new Injector([
Engine,
bind(Car).toFactory([Engine], (e) => new SportsCar(e))
bind(Car).toFactory(sportsCarFactory)
]);
var car = injector.get(Car);
expect(car).toBeAnInstanceOf(SportsCar);
expect(car.engine).toBeAnInstanceOf(Engine);
});
it('should support overriding factory dependencies', function () {
var injector = new Injector([
Engine,
bind(Car).toFactory((e) => new SportsCar(e), {dependencies: [Engine]})
]);
var car = injector.get(Car);
@ -181,7 +196,7 @@ export function main() {
var injector = new Injector([
Car,
bind(Engine).toFactory([], () => isBroken ? new BrokenEngine() : new Engine())
bind(Engine).toFactory(() => isBroken ? new BrokenEngine() : new Engine())
]);
expect(() => injector.get(Car)).toThrow();