cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test(ivy): add fixme to a failing testbed test (#27278)

Browse Source 
PR Close #27278
This commit is contained in:
Igor Minar 2018-11-17 22:33:10 -08:00 committed by Jason Aden
parent f7ba4b2ff9
commit d35d164ece
3 changed files with 19 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/compiler-cli/integrationtest/bazel/injectable_def/app/test/BUILD.bazel
View File

@ -31,6 +31,7 @@ jasmine_node_test(
":test_lib", ":test_lib",
"//packages/platform-server", "//packages/platform-server",
"//packages/platform-server/testing", "//packages/platform-server/testing",
"//packages/private/testing",
"//tools/testing:node", "//tools/testing:node",
], ],
) )

30
packages/compiler-cli/integrationtest/bazel/injectable_def/app/test/app_spec.ts
View File

@ -9,6 +9,7 @@
import {Component, INJECTOR, Injectable, NgModule} from '@angular/core'; import {Component, INJECTOR, Injectable, NgModule} from '@angular/core';
import {TestBed} from '@angular/core/testing'; import {TestBed} from '@angular/core/testing';
import {renderModuleFactory} from '@angular/platform-server'; import {renderModuleFactory} from '@angular/platform-server';
import {fixmeIvy} from '@angular/private/testing';
import {BasicAppModuleNgFactory} from 'app_built/src/basic.ngfactory'; import {BasicAppModuleNgFactory} from 'app_built/src/basic.ngfactory';
import {DepAppModuleNgFactory} from 'app_built/src/dep.ngfactory'; import {DepAppModuleNgFactory} from 'app_built/src/dep.ngfactory';
import {HierarchyAppModuleNgFactory} from 'app_built/src/hierarchy.ngfactory'; import {HierarchyAppModuleNgFactory} from 'app_built/src/hierarchy.ngfactory';
@ -167,20 +168,21 @@ describe('ngInjectableDef Bazel Integration', () => {
expect(TestBed.get(INJECTOR).get('foo')).toEqual('bar'); expect(TestBed.get(INJECTOR).get('foo')).toEqual('bar');
}); });
it('Component injector understands requests for INJECTABLE', () => { fixmeIvy('FW-646: Directive providers don\'t support primitive types') &&
@Component({ it('Component injector understands requests for INJECTABLE', () => {
selector: 'test-cmp', @Component({
template: 'test', selector: 'test-cmp',
providers: [{provide: 'foo', useValue: 'bar'}], template: 'test',
}) providers: [{provide: 'foo', useValue: 'bar'}],
class TestCmp { })
} class TestCmp {
}
TestBed.configureTestingModule({ TestBed.configureTestingModule({
declarations: [TestCmp], declarations: [TestCmp],
}); });
const fixture = TestBed.createComponent(TestCmp); const fixture = TestBed.createComponent(TestCmp);
expect(fixture.componentRef.injector.get(INJECTOR).get('foo')).toEqual('bar'); expect(fixture.componentRef.injector.get(INJECTOR).get('foo')).toEqual('bar');
}); });
}); });

4
packages/compiler-cli/integrationtest/bazel/injector_def/ivy_build/app/test/BUILD.bazel
View File

@ -11,8 +11,8 @@ ts_library(
], ],
), ),
tags = [ tags = [
"ivy-only",
"fixme-ivy-aot", "fixme-ivy-aot",
"ivy-only",
], ],
deps = [ deps = [
"//packages/compiler-cli/integrationtest/bazel/injector_def/ivy_build/app", "//packages/compiler-cli/integrationtest/bazel/injector_def/ivy_build/app",
@ -25,8 +25,8 @@ jasmine_node_test(
name = "test", name = "test",
bootstrap = ["angular/tools/testing/init_node_spec.js"], bootstrap = ["angular/tools/testing/init_node_spec.js"],
tags = [ tags = [
"ivy-only",
"fixme-ivy-aot", "fixme-ivy-aot",
"ivy-only",
], ],
deps = [ deps = [
":test_lib", ":test_lib",