cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(dev-infra): use the exec() helper from utils/shelljs whenever possible (#37444)

Browse Source 
There is an `exec()` helper provided by `utils/shelljs.ts`, which is a
wrapper around ShellJS' `exec()` with some default options (currently
`silent: true`). The intention is to avoid having to pass these options
to every invocation of the `exec()` function.

This commit updates all code inside `dev-infra/` to use this helper
whenever possible).

NOTE: For simplicity, the `utils/shelljs` helper does not support some
      of the less common call signatures of the original `exec()`
      helper, so in some cases we still need to use the original.

PR Close #37444
This commit is contained in:
George Kalpakas
2020-06-05 11:03:32 +03:00
committed by atscott
parent e31208beb1
commit d4c0962c7b
6 changed files with 12 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
dev-infra/utils/config.ts
View File

@ -8,9 +8,9 @@
import {existsSync} from 'fs';
import {dirname, join} from 'path';
import {exec} from 'shelljs';
import {error} from './console';
import {exec} from './shelljs';
import {isTsNodeAvailable} from './ts-node';
/**
@ -119,7 +119,7 @@ export function assertNoErrors(errors: string[]) {
/** Gets the path of the directory for the repository base. */
export function getRepoBaseDir() {
const baseRepoDir = exec(`git rev-parse --show-toplevel`, {silent: true});
const baseRepoDir = exec(`git rev-parse --show-toplevel`);
if (baseRepoDir.code) {
throw Error(
`Unable to find the path to the base directory of the repository.\n` +