refactor: add leading underscore to private fields

Closes #4001
This commit is contained in:
Harry Terkelsen
2015-09-04 15:09:02 -07:00
committed by Harry Terkelsen
parent c320240086
commit d8c5ab232c
16 changed files with 150 additions and 138 deletions

View File

@ -33,9 +33,9 @@ class OrderItem {
class Order {
constructor(public orderId: number, public customerName: string, public limit: number,
private dataService: DataService) {}
private _dataService: DataService) {}
get items(): OrderItem[] { return this.dataService.itemsFor(this); }
get items(): OrderItem[] { return this._dataService.itemsFor(this); }
get total(): number { return this.items.map(i => i.total).reduce((a, b) => a + b); }
}
@ -113,8 +113,8 @@ class DataService {
class OrderListComponent {
orders: Order[];
constructor(private service: DataService) { this.orders = service.orders; }
select(order: Order): void { this.service.currentOrder = order; }
constructor(private _service: DataService) { this.orders = _service.orders; }
select(order: Order): void { this._service.currentOrder = order; }
}
@ -182,13 +182,13 @@ class OrderItemComponent {
directives: [FORM_DIRECTIVES, OrderItemComponent, NgFor, NgIf]
})
class OrderDetailsComponent {
constructor(private service: DataService) {}
constructor(private _service: DataService) {}
get order(): Order { return this.service.currentOrder; }
get order(): Order { return this._service.currentOrder; }
deleteItem(item: OrderItem): void { this.service.deleteItem(item); }
deleteItem(item: OrderItem): void { this._service.deleteItem(item); }
addItem(): void { this.service.addItemForOrder(this.order); }
addItem(): void { this._service.addItemForOrder(this.order); }
}
@Component({selector: 'order-management-app', viewBindings: [DataService]})

View File

@ -115,8 +115,8 @@ class DataService {
directives: [FORM_DIRECTIVES]
})
class FullNameComponent {
constructor(private service: DataService) {}
get person(): Person { return this.service.currentPerson; }
constructor(private _service: DataService) {}
get person(): Person { return this._service.currentPerson; }
}
@Component({selector: 'person-detail-cmp'})
@ -163,8 +163,8 @@ class FullNameComponent {
directives: [FORM_DIRECTIVES, NgIf]
})
class PersonsDetailComponent {
constructor(private service: DataService) {}
get person(): Person { return this.service.currentPerson; }
constructor(private _service: DataService) {}
get person(): Person { return this._service.currentPerson; }
}
@Component({selector: 'persons-cmp'})
@ -186,9 +186,9 @@ class PersonsDetailComponent {
class PersonsComponent {
persons: Person[];
constructor(private service: DataService) { this.persons = service.persons; }
constructor(private _service: DataService) { this.persons = _service.persons; }
select(person: Person): void { this.service.currentPerson = person; }
select(person: Person): void { this._service.currentPerson = person; }
}