cargdev/angular
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

build: update to rules_typescript 0.25.1 (#28896)

Browse Source 
* build_bazel_rules_typescript renamed to npm_bazel_typescript
* build_bazel_rules_karma renamed to npm_bazel_karma
* browser_repositories.bzl removed and now using @npm_bazel_karma//:browser_repositories.bzl
* includes some fixes for future ts_library devmode es2015 support but some failure still remain when devmode is es2015 so this PR keeps it as es5 using the bazelOptions.devmodeTargetOverride tsconfig setting

PR Close #28896
This commit is contained in:
Greg Magolan
2019-02-08 14:01:51 -08:00
committed by Ben Lesh
parent d0018e6bf6
commit d91ecd2c8b
89 changed files with 231 additions and 499 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
packages/platform-browser-dynamic/test/metadata_overrider_spec.ts
View File

@ -22,13 +22,16 @@ interface OtherMetadataType extends SomeMetadataType {
class SomeMetadata implements SomeMetadataType {
plainProp: string;
private _getterProp: string;
get getterProp(): string { return this._getterProp; }
arrayProp: any[];
constructor(options: SomeMetadataType) {
this.plainProp = options.plainProp !;
this._getterProp = options.getterProp !;
this.arrayProp = options.arrayProp !;
Object.defineProperty(this, 'getterProp', {
enumerable: true, // getters are non-enumerable by default in es2015
get: () => this._getterProp,
});
}
}