From d9f33160214d74c0af7251a7cdedd3ed224ef143 Mon Sep 17 00:00:00 2001 From: Paul Gschwendtner Date: Thu, 31 Jan 2019 22:57:45 +0100 Subject: [PATCH] build: fix bazel protractor tests not capturing console output (#28697) Currently we depend on the "rules_webtesting" version that is installed by "rules_typescript//:package.bzl". This version of the webtesting rules comes with a very old version of Chromium and the `chromedriver` that does not support capturing console errors properly (with stack traces). Since we have a few e2e tests that depend on console output (e.g. playground/src/source-map), we need to make sure that these tests can pass upon Bazel migration. **Note for patch version**: Technically this commit is no longer updating the `rules_webtesting` version because a different PR/commit already updated the version transitively in `master & patch` and reverted 0094b99176264b27582ab620565632788cab66c5 partially, so in order to keep master and patch in sync, we should not update the version of `rules_webtesting`. PR Close #28697 --- modules/playground/e2e_test/sourcemap/sourcemap_spec.ts | 3 --- 1 file changed, 3 deletions(-) diff --git a/modules/playground/e2e_test/sourcemap/sourcemap_spec.ts b/modules/playground/e2e_test/sourcemap/sourcemap_spec.ts index 0de005d2e7..2a2155dd8c 100644 --- a/modules/playground/e2e_test/sourcemap/sourcemap_spec.ts +++ b/modules/playground/e2e_test/sourcemap/sourcemap_spec.ts @@ -20,9 +20,6 @@ describe('sourcemaps', function() { $('error-app .errorButton').click(); - // TODO(tbosch): Bug in ChromeDriver: Need to execute at least one command - // so that the browser logs can be read out! - browser.executeScript('1+1'); browser.manage().logs().get(logging.Type.BROWSER).then(function(logs: any) { let errorLine: number = null; let errorColumn: number = null;