build: re-enable template type-checking for various targets across the repo (#34144)

Various targets have their template type-checking disabled in the past.

There is no reason for this any more.

The only target that was tricky was packages/examples/core:core_examples
which was quite broken and I had to fix it up.

Template typechecking is still disabled under blaze, see FW-1753 for more
info.

PR Close #34144
This commit is contained in:
Igor Minar
2019-11-29 01:54:33 -08:00
committed by Miško Hevery
parent 572e731b63
commit daa403fb61
38 changed files with 14 additions and 79 deletions

View File

@ -305,6 +305,9 @@ def _ngc_tsconfig(ctx, files, srcs, **kwargs):
"enableSummariesForJit": is_legacy_ngc,
"enableIvy": is_ivy_enabled(ctx),
"fullTemplateTypeCheck": ctx.attr.type_check,
# TODO(alxhub/arick): template type-checking in g3 is currently disabled because of
# preexisting failures. Reenable once g3 is fixed: FW-1753
"ivyTemplateTypeCheck": _is_bazel(),
# In Google3 we still want to use the symbol factory re-exports in order to
# not break existing apps inside Google. Unlike Bazel, Google3 does not only
# enforce strict dependencies of source files, but also for generated files