style: enforce disallowance of object constructor (#33211)

Applying the `prefer-literal` tslint rule to object enforces the style guide rule https://google.github.io/styleguide/jsguide.html#features-objects-ctor

PR Close #33211

packages/core/test/change_detection/change_detector_util_spec.ts

@@ -16,41 +16,41 @@ import {devModeEqual} from '@angular/core/src/change_detection/change_detection_
         expect(devModeEqual(['one'], ['one', 'two'])).toBe(false);
         expect(devModeEqual(['one', 'two'], ['one'])).toBe(false);
         expect(devModeEqual(['one'], 'one')).toBe(false);
-        expect(devModeEqual(['one'], new Object())).toBe(false);
+        expect(devModeEqual(['one'], {})).toBe(false);
         expect(devModeEqual('one', ['one'])).toBe(false);
-        expect(devModeEqual(new Object(), ['one'])).toBe(false);
+        expect(devModeEqual({}, ['one'])).toBe(false);
       });
 
       it('should compare primitive numbers', () => {
         expect(devModeEqual(1, 1)).toBe(true);
         expect(devModeEqual(1, 2)).toBe(false);
-        expect(devModeEqual(new Object(), 2)).toBe(false);
-        expect(devModeEqual(1, new Object())).toBe(false);
+        expect(devModeEqual({}, 2)).toBe(false);
+        expect(devModeEqual(1, {})).toBe(false);
       });
 
       it('should compare primitive strings', () => {
         expect(devModeEqual('one', 'one')).toBe(true);
         expect(devModeEqual('one', 'two')).toBe(false);
-        expect(devModeEqual(new Object(), 'one')).toBe(false);
-        expect(devModeEqual('one', new Object())).toBe(false);
+        expect(devModeEqual({}, 'one')).toBe(false);
+        expect(devModeEqual('one', {})).toBe(false);
       });
 
       it('should compare primitive booleans', () => {
         expect(devModeEqual(true, true)).toBe(true);
         expect(devModeEqual(true, false)).toBe(false);
-        expect(devModeEqual(new Object(), true)).toBe(false);
-        expect(devModeEqual(true, new Object())).toBe(false);
+        expect(devModeEqual({}, true)).toBe(false);
+        expect(devModeEqual(true, {})).toBe(false);
       });
 
       it('should compare null', () => {
         expect(devModeEqual(null, null)).toBe(true);
         expect(devModeEqual(null, 1)).toBe(false);
-        expect(devModeEqual(new Object(), null)).toBe(false);
-        expect(devModeEqual(null, new Object())).toBe(false);
+        expect(devModeEqual({}, null)).toBe(false);
+        expect(devModeEqual(null, {})).toBe(false);
       });
 
       it('should return true for other objects',
-         () => { expect(devModeEqual(new Object(), new Object())).toBe(true); });
+         () => { expect(devModeEqual({}, {})).toBe(true); });
     });
   });
 }

packages/core/test/view/anchor_spec.ts

@@ -40,7 +40,7 @@ import {compViewDef, createAndGetRootNodes} from './helper';
       });
 
       it('should add debug information to the renderer', () => {
-        const someContext = new Object();
+        const someContext = {};
         const {view, rootNodes} = createAndGetRootNodes(
             compViewDef([anchorDef(NodeFlags.None, null, null, 0)]), someContext);
         expect(getDebugNode(rootNodes[0]) !.nativeNode).toBe(asElementData(view, 0).renderElement);

packages/core/test/view/element_spec.ts

@@ -62,7 +62,7 @@ const removeEventListener = 'removeEventListener';
       });
 
       it('should add debug information to the renderer', () => {
-        const someContext = new Object();
+        const someContext = {};
         const {view, rootNodes} = createAndGetRootNodes(
             compViewDef([elementDef(0, NodeFlags.None, null, null, 0, 'div')]), someContext);
         expect(getDebugNode(rootNodes[0]) !.nativeNode).toBe(asElementData(view, 0).renderElement);

packages/core/test/view/embedded_view_spec.ts

@@ -16,8 +16,8 @@ import {compViewDef, compViewDefFactory, createAndGetRootNodes, createEmbeddedVi
   describe(`Embedded Views`, () => {
 
     it('should create embedded views with the right context', () => {
-      const parentContext = new Object();
-      const childContext = new Object();
+      const parentContext = {};
+      const childContext = {};
 
       const {view: parentView} = createAndGetRootNodes(
           compViewDef([

packages/core/test/view/text_spec.ts

@@ -41,7 +41,7 @@ import {ARG_TYPE_VALUES, checkNodeInlineOrDynamic, compViewDef, createAndGetRoot
       });
 
       it('should add debug information to the renderer', () => {
-        const someContext = new Object();
+        const someContext = {};
         const {view, rootNodes} =
             createAndGetRootNodes(compViewDef([textDef(0, null, ['a'])]), someContext);
         expect(getDebugNode(rootNodes[0]) !.nativeNode).toBe(asTextData(view, 0).renderText);