From dc2464eaaad44819050bb63a757252bce4f242c2 Mon Sep 17 00:00:00 2001 From: Kara Erickson Date: Mon, 5 Nov 2018 19:00:11 -0800 Subject: [PATCH] fix(ivy): jit should handle undefined type in constructor deps (#26956) PR Close #26956 --- packages/core/src/render3/jit/util.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/core/src/render3/jit/util.ts b/packages/core/src/render3/jit/util.ts index c46504baef..0bcc8da424 100644 --- a/packages/core/src/render3/jit/util.ts +++ b/packages/core/src/render3/jit/util.ts @@ -49,7 +49,10 @@ function reflectDependency(compiler: CompilerFacade, dep: any | any[]): R3Depend } for (let j = 0; j < dep.length; j++) { const param = dep[j]; - if (param instanceof Optional || param.__proto__.ngMetadataName === 'Optional') { + if (param === undefined) { + // param may be undefined if type of dep is not set by ngtsc + continue; + } else if (param instanceof Optional || param.__proto__.ngMetadataName === 'Optional') { meta.optional = true; } else if (param instanceof SkipSelf || param.__proto__.ngMetadataName === 'SkipSelf') { meta.skipSelf = true;