cargdev/angular
1
0
Fork 0
Code Issues 16 Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "fix(elements): fire custom element output events during component initialization"

Browse Source 
This reverts commit 454e073918. This
commit was found to cause some tests inside Google to fail.
This commit is contained in:
atscott
2020-06-10 17:31:04 +00:00
parent 99c41d6db0
commit dc9da17f37
4 changed files with 11 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
packages/elements/test/create-custom-element_spec.ts
View File

@ -117,16 +117,6 @@ if (browserDetection.supportsCustomElements) {
expect(eventValue).toEqual(null);
});
it('should listen to output events during initialization', () => {
const events: string[] = [];
const element = new NgElementCtor(injector);
element.addEventListener('strategy-event', evt => events.push((evt as CustomEvent).detail));
element.connectedCallback();
expect(events).toEqual(['connect']);
});
it('should properly set getters/setters on the element', () => {
const element = new NgElementCtor(injector);
element.fooFoo = 'foo-foo-value';
@ -265,7 +255,6 @@ if (browserDetection.supportsCustomElements) {
events = new Subject<NgElementStrategyEvent>();
connect(element: HTMLElement): void {
this.events.next({name: 'strategy-event', value: 'connect'});
this.connectedElement = element;
}