build: unable to accept new symbol-extractor golden on windows (#30127)

Currently when working on Windows, it's not possible to accept a new
golden for a `symbol-extractor` Bazel test. This is because the generated
executable output from the `nodejs_binary` rule (without a macro) misses
a Windows executable wrapper that sets up the proper environment
variables for the runfiles. Causing the following failure on Windows:

```
 >>>> FAIL: RUNFILES environment variable is not set. <<<<
```

PR Close #30127
This commit is contained in:
Paul Gschwendtner
2019-04-25 20:41:05 +02:00
committed by Andrew Kushnir
parent 124e49752f
commit dd59b1d371
2 changed files with 5 additions and 7 deletions

View File

@ -43,7 +43,7 @@ function main(argv: [string, string, string] | [string, string]): boolean {
const defineFlag = (compile !== 'legacy') ? `--define=compile=${compile} ` : '';
console.error(`TEST FAILED!`);
console.error(` To update the golden file run: `);
console.error(` yarn bazel run ${defineFlag}${process.env['BAZEL_TARGET']}.accept`);
console.error(` yarn bazel run ${defineFlag}${process.env['TEST_TARGET']}.accept`);
}
}
return passed;