feat(build): require parameter types

Fixes #2833

modules/angular2/src/change_detection/parser/ast.ts

@@ -3,11 +3,11 @@ import {List, Map, ListWrapper, StringMapWrapper} from "angular2/src/facade/coll
 import {Locals} from "./locals";
 
 export class AST {
-  eval(context, locals: Locals) { throw new BaseException("Not supported"); }
+  eval(context: any, locals: Locals): any { throw new BaseException("Not supported"); }
 
   get isAssignable(): boolean { return false; }
 
-  assign(context, locals: Locals, value) { throw new BaseException("Not supported"); }
+  assign(context: any, locals: Locals, value: any) { throw new BaseException("Not supported"); }
 
   visit(visitor: AstVisitor): any { return null; }
 
@@ -15,7 +15,7 @@ export class AST {
 }
 
 export class EmptyExpr extends AST {
-  eval(context, locals: Locals): any { return null; }
+  eval(context: any, locals: Locals): any { return null; }
 
   visit(visitor: AstVisitor) {
     // do nothing
@@ -23,7 +23,7 @@ export class EmptyExpr extends AST {
 }
 
 export class ImplicitReceiver extends AST {
-  eval(context, locals: Locals): any { return context; }
+  eval(context: any, locals: Locals): any { return context; }
 
   visit(visitor: AstVisitor): any { return visitor.visitImplicitReceiver(this); }
 }
@@ -34,7 +34,7 @@ export class ImplicitReceiver extends AST {
 export class Chain extends AST {
   constructor(public expressions: List<any>) { super(); }
 
-  eval(context, locals: Locals): any {
+  eval(context: any, locals: Locals): any {
     var result;
     for (var i = 0; i < this.expressions.length; i++) {
       var last = this.expressions[i].eval(context, locals);
@@ -49,7 +49,7 @@ export class Chain extends AST {
 export class Conditional extends AST {
   constructor(public condition: AST, public trueExp: AST, public falseExp: AST) { super(); }
 
-  eval(context, locals: Locals): any {
+  eval(context: any, locals: Locals): any {
     if (this.condition.eval(context, locals)) {
       return this.trueExp.eval(context, locals);
     } else {
@@ -63,7 +63,7 @@ export class Conditional extends AST {
 export class If extends AST {
   constructor(public condition: AST, public trueExp: AST, public falseExp?: AST) { super(); }
 
-  eval(context, locals) {
+  eval(context: any, locals: Locals) {
     if (this.condition.eval(context, locals)) {
       this.trueExp.eval(context, locals);
     } else if (isPresent(this.falseExp)) {
@@ -80,7 +80,7 @@ export class AccessMember extends AST {
     super();
   }
 
-  eval(context, locals: Locals): any {
+  eval(context: any, locals: Locals): any {
     if (this.receiver instanceof ImplicitReceiver && isPresent(locals) &&
         locals.contains(this.name)) {
       return locals.get(this.name);
@@ -92,7 +92,7 @@ export class AccessMember extends AST {
 
   get isAssignable(): boolean { return true; }
 
-  assign(context, locals: Locals, value): any {
+  assign(context: any, locals: Locals, value: any): any {
     var evaluatedContext = this.receiver.eval(context, locals);
 
     if (this.receiver instanceof ImplicitReceiver && isPresent(locals) &&
@@ -112,7 +112,7 @@ export class SafeAccessMember extends AST {
     super();
   }
 
-  eval(context, locals: Locals): any {
+  eval(context: any, locals: Locals): any {
     var evaluatedReceiver = this.receiver.eval(context, locals);
     return isBlank(evaluatedReceiver) ? null : this.getter(evaluatedReceiver);
   }
@@ -123,7 +123,7 @@ export class SafeAccessMember extends AST {
 export class KeyedAccess extends AST {
   constructor(public obj: AST, public key: AST) { super(); }
 
-  eval(context, locals: Locals): any {
+  eval(context: any, locals: Locals): any {
     var obj: any = this.obj.eval(context, locals);
     var key: any = this.key.eval(context, locals);
     return obj[key];
@@ -131,7 +131,7 @@ export class KeyedAccess extends AST {
 
   get isAssignable(): boolean { return true; }
 
-  assign(context, locals: Locals, value): any {
+  assign(context: any, locals: Locals, value: any): any {
     var obj: any = this.obj.eval(context, locals);
     var key: any = this.key.eval(context, locals);
     obj[key] = value;
@@ -150,7 +150,7 @@ export class BindingPipe extends AST {
 export class LiteralPrimitive extends AST {
   constructor(public value) { super(); }
 
-  eval(context, locals: Locals): any { return this.value; }
+  eval(context: any, locals: Locals): any { return this.value; }
 
   visit(visitor: AstVisitor): any { return visitor.visitLiteralPrimitive(this); }
 }
@@ -158,7 +158,7 @@ export class LiteralPrimitive extends AST {
 export class LiteralArray extends AST {
   constructor(public expressions: List<any>) { super(); }
 
-  eval(context, locals: Locals): any {
+  eval(context: any, locals: Locals): any {
     return ListWrapper.map(this.expressions, (e) => e.eval(context, locals));
   }
 
@@ -168,7 +168,7 @@ export class LiteralArray extends AST {
 export class LiteralMap extends AST {
   constructor(public keys: List<any>, public values: List<any>) { super(); }
 
-  eval(context, locals: Locals): any {
+  eval(context: any, locals: Locals): any {
     var res = StringMapWrapper.create();
     for (var i = 0; i < this.keys.length; ++i) {
       StringMapWrapper.set(res, this.keys[i], this.values[i].eval(context, locals));
@@ -182,7 +182,7 @@ export class LiteralMap extends AST {
 export class Interpolation extends AST {
   constructor(public strings: List<any>, public expressions: List<any>) { super(); }
 
-  eval(context, locals): any {
+  eval(context: any, locals: Locals): any {
     throw new BaseException("evaluating an Interpolation is not supported");
   }
 
@@ -192,7 +192,7 @@ export class Interpolation extends AST {
 export class Binary extends AST {
   constructor(public operation: string, public left: AST, public right: AST) { super(); }
 
-  eval(context, locals: Locals): any {
+  eval(context: any, locals: Locals): any {
     var left: any = this.left.eval(context, locals);
     switch (this.operation) {
       case '&&':
@@ -243,15 +243,15 @@ export class Binary extends AST {
 export class PrefixNot extends AST {
   constructor(public expression: AST) { super(); }
 
-  eval(context, locals: Locals): any { return !this.expression.eval(context, locals); }
+  eval(context: any, locals: Locals): any { return !this.expression.eval(context, locals); }
 
   visit(visitor: AstVisitor): any { return visitor.visitPrefixNot(this); }
 }
 
 export class Assignment extends AST {
-  constructor(public target: AST, public value: AST) { super(); }
+  constructor(public target: AST, public value: any) { super(); }
 
-  eval(context, locals: Locals): any {
+  eval(context: any, locals: Locals): any {
     return this.target.assign(context, locals, this.value.eval(context, locals));
   }
 
@@ -264,7 +264,7 @@ export class MethodCall extends AST {
     super();
   }
 
-  eval(context, locals: Locals): any {
+  eval(context: any, locals: Locals): any {
     var evaluatedArgs = evalList(context, locals, this.args);
     if (this.receiver instanceof ImplicitReceiver && isPresent(locals) &&
         locals.contains(this.name)) {
@@ -285,7 +285,7 @@ export class SafeMethodCall extends AST {
     super();
   }
 
-  eval(context, locals: Locals): any {
+  eval(context: any, locals: Locals): any {
     var evaluatedReceiver = this.receiver.eval(context, locals);
     if (isBlank(evaluatedReceiver)) return null;
     var evaluatedArgs = evalList(context, locals, this.args);
@@ -298,7 +298,7 @@ export class SafeMethodCall extends AST {
 export class FunctionCall extends AST {
   constructor(public target: AST, public args: List<any>) { super(); }
 
-  eval(context, locals: Locals): any {
+  eval(context: any, locals: Locals): any {
     var obj: any = this.target.eval(context, locals);
     if (!(obj instanceof Function)) {
       throw new BaseException(`${obj} is not a function`);
@@ -312,11 +312,13 @@ export class FunctionCall extends AST {
 export class ASTWithSource extends AST {
   constructor(public ast: AST, public source: string, public location: string) { super(); }
 
-  eval(context, locals: Locals): any { return this.ast.eval(context, locals); }
+  eval(context: any, locals: Locals): any { return this.ast.eval(context, locals); }
 
   get isAssignable(): boolean { return this.ast.isAssignable; }
 
-  assign(context, locals: Locals, value): any { return this.ast.assign(context, locals, value); }
+  assign(context: any, locals: Locals, value: any): any {
+    return this.ast.assign(context, locals, value);
+  }
 
   visit(visitor: AstVisitor): any { return this.ast.visit(visitor); }
 

modules/angular2/src/change_detection/parser/locals.ts

@@ -28,7 +28,7 @@ export class Locals {
     throw new BaseException(`Cannot find '${name}'`);
   }
 
-  set(name: string, value): void {
+  set(name: string, value: any): void {
     // TODO(rado): consider removing this check if we can guarantee this is not
     // exposed to the public API.
     // TODO: vsavkin maybe it should check only the local map

modules/angular2/src/change_detection/parser/parser.ts

@@ -479,7 +479,7 @@ class _ParseAST {
     return new LiteralMap(keys, values);
   }
 
-  parseAccessMemberOrMethodCall(receiver, isSafe: boolean = false): AST {
+  parseAccessMemberOrMethodCall(receiver: AST, isSafe: boolean = false): AST {
     let id = this.expectIdentifierOrKeyword();
 
     if (this.optionalCharacter($LPAREN)) {