From df7f3b04b5189401814da29433f64c7915660fe9 Mon Sep 17 00:00:00 2001 From: Sonu Kapoor Date: Mon, 3 Aug 2020 12:32:14 -0400 Subject: [PATCH] fix(service-worker): fix the chrome debugger syntax highlighter (#38332) The Chrome debugger is not able to render the syntax properly when the code contains backticks. This is a known issue in Chrome and they have an open [issue](https://bugs.chromium.org/p/chromium/issues/detail?id=659515) for that. This commit adds the work-around to use double backslash with one backtick ``\\` `` at the end of the line. This can be reproduced by running the following command: `yarn bazel test //packages/forms/test --config=debug` When opening the chrome debugger tools, you should see the correct code highlighting syntax. PR Close #38332 --- packages/service-worker/worker/src/driver.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/service-worker/worker/src/driver.ts b/packages/service-worker/worker/src/driver.ts index 86c31d843d..c0875e0c66 100644 --- a/packages/service-worker/worker/src/driver.ts +++ b/packages/service-worker/worker/src/driver.ts @@ -720,7 +720,11 @@ export class Driver implements Debuggable, UpdateSource { private async deleteAllCaches(): Promise { await (await this.scope.caches.keys()) - .filter(key => key.startsWith(`${this.adapter.cacheNamePrefix}:`)) + // The Chrome debugger is not able to render the syntax properly when the + // code contains backticks. This is a known issue in Chrome and they have an + // open [issue](https://bugs.chromium.org/p/chromium/issues/detail?id=659515) for that. + // As a work-around for the time being, we can use \\ ` at the end of the line. + .filter(key => key.startsWith(`${this.adapter.cacheNamePrefix}:`)) // ` .reduce(async (previous, key) => { await Promise.all([ previous,