cargdev/angular
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ivy): component destroy hook called twice when configured as provider (#28470)

Browse Source 
Fixes the `ngOnDestroy` hook on a component or directive being called twice, if the type is also registered as a provider.

This PR resolves FW-1010.

PR Close #28470
This commit is contained in:
Kristiyan Kostadinov
2019-01-31 10:38:43 +01:00
committed by Igor Minar
parent 0ea216b993
commit e1aaa7ec48
12 changed files with 285 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
tools/material-ci/angular_material_test_blocklist.js vendored
View File

@ -237,46 +237,6 @@ window.testBlocklist = {
"error": "TypeError: Cannot read property 'accordion' of undefined",
"notes": "Unknown"
},
"CdkDrag standalone draggable should enable native drag interactions when there is a drag handle": {
"error": "TypeError: Cannot read property 'removeEventListener' of null",
"notes": "FW-1010: onDestroy hook is called twice for directives that are also used in a provider"
},
"CdkDrag draggable with a handle should not be able to drag the entire element if it has a handle": {
"error": "TypeError: Cannot read property 'removeEventListener' of null",
"notes": "FW-1010: onDestroy hook is called twice for directives that are also used in a provider"
},
"CdkDrag draggable with a handle should be able to drag an element using its handle": {
"error": "TypeError: Cannot read property 'removeEventListener' of null",
"notes": "FW-1010: onDestroy hook is called twice for directives that are also used in a provider"
},
"CdkDrag draggable with a handle should not be able to drag the element if the handle is disabled": {
"error": "TypeError: Cannot read property 'removeEventListener' of null",
"notes": "FW-1010: onDestroy hook is called twice for directives that are also used in a provider"
},
"CdkDrag draggable with a handle should not be able to drag using the handle if the element is disabled": {
"error": "TypeError: Cannot read property 'removeEventListener' of null",
"notes": "FW-1010: onDestroy hook is called twice for directives that are also used in a provider"
},
"CdkDrag draggable with a handle should be able to use a handle that was added after init": {
"error": "TypeError: Cannot read property 'removeEventListener' of null",
"notes": "FW-1010: onDestroy hook is called twice for directives that are also used in a provider"
},
"CdkDrag draggable with a handle should be able to use more than one handle to drag the element": {
"error": "TypeError: Cannot read property 'removeEventListener' of null",
"notes": "FW-1010: onDestroy hook is called twice for directives that are also used in a provider"
},
"CdkDrag draggable with a handle should be able to drag with a handle that is not a direct descendant": {
"error": "TypeError: Cannot read property 'removeEventListener' of null",
"notes": "FW-1010: onDestroy hook is called twice for directives that are also used in a provider"
},
"CdkDrag draggable with a handle should disable the tap highlight while dragging via the handle": {
"error": "TypeError: Cannot read property 'removeEventListener' of null",
"notes": "FW-1010: onDestroy hook is called twice for directives that are also used in a provider"
},
"CdkDrag draggable with a handle should preserve any existing `webkitTapHighlightColor`": {
"error": "TypeError: Cannot read property 'removeEventListener' of null",
"notes": "FW-1010: onDestroy hook is called twice for directives that are also used in a provider"
},
"CdkDrag in a drop container should be able to customize the preview element": {
"error": "Error: Expected cdk-drag cdk-drag-preview to contain 'custom-preview'.",
"notes": "Unknown"