cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(animations): report correct totalTime value even during noOp animations (#22225)

Browse Source 
This patch ensures that if the NoopAnimationsModule is used then it will
correctly report the associated `totalTime` property within the emitted
AnimationEvent instance when an animation event trigger is fired.

BREAKING CHANGE: When animation is trigged within a disabled zone, the
associated event (which an instance of AnimationEvent) will no longer
report the totalTime as 0 (it will emit the actual time of the
animation). To detect if an animation event is reporting a disabled
animation then the `event.disabled` property can be used instead.

PR Close #22225
This commit is contained in:
Matias Niemelä
2018-02-14 10:12:10 -08:00
committed by Victor Berchet
parent 884de18cba
commit e1bf067090
12 changed files with 108 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/animations/browser/testing/src/mock_animation_driver.ts
View File

@ -58,7 +58,7 @@ export class MockAnimationPlayer extends NoopAnimationPlayer {
public element: any, public keyframes: {[key: string]: string | number}[],
public duration: number, public delay: number, public easing: string,
public previousPlayers: any[]) {
super();
super(duration, delay);
if (allowPreviousPlayerStylesMerge(duration, delay)) {
previousPlayers.forEach(player => {
@ -68,8 +68,6 @@ export class MockAnimationPlayer extends NoopAnimationPlayer {
}
});
}
this.totalTime = delay + duration;
}
/* @internal */