cargdev/angular
1
0
Fork 0
Code Issues 17 Pull Requests Actions Packages Projects Releases Wiki Activity

perf(ivy): minimise writes to the lView[BINDING_INDEX] / binding root (#32263)

Browse Source 
This commit removes all the (duplicated) logic of setting lView[BINDING_INDEX]
from `enterView`. `enterView` is on the critcal path perf-wise so we should
avoid having any logic in there and minimise memory read / write.

This simple refactoring in this PR reduces time spent in noop change detection
by ~12% (from ~800ms down to ~700ms on a local machine where measurements were
taken).

PR Close #32263
This commit is contained in:
Pawel Kozlowski
2019-08-22 11:12:04 +02:00
committed by atscott
parent 860b5d0efa
commit e3422e0aed
2 changed files with 1 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/core/src/render3/state.ts
View File

@ -414,10 +414,6 @@ export function setCurrentQueryIndex(value: number): void {
export function enterView(newView: LView, hostTNode: TElementNode | TViewNode | null): LView {
ngDevMode && assertLViewOrUndefined(newView);
const oldView = lView;
if (newView) {
const tView = newView[TVIEW];
bindingRootIndex = tView.bindingStartIndex;
}
previousOrParentTNode = hostTNode !;
isParent = true;