cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(language-service): hover information for component NgModules (#33118)

Browse Source 
Enables providing information about the NgModule a component is in when
its selector is hovered on in a template. Also enables differentiation
of a component and a directive when a directive class name is hovered
over in a TypeScript file.

Next step is to enable hover information for directives.

Part of #32565.

PR Close #33118
This commit is contained in:
ayazhafiz
2019-10-11 19:15:07 -05:00
committed by Miško Hevery
parent 0de2a5e408
commit e409ed0eab
4 changed files with 64 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
packages/language-service/test/hover_spec.ts
View File

@ -103,7 +103,7 @@ describe('hover', () => {
expect(quickInfo).toBeTruthy();
const {textSpan, displayParts} = quickInfo !;
expect(textSpan).toEqual(marker);
expect(toText(displayParts)).toBe('(component) TestComponent');
expect(toText(displayParts)).toBe('(component) AppModule.TestComponent: class');
});
it('should be able to find an event provider', () => {
@ -149,7 +149,7 @@ describe('hover', () => {
expect(quickInfo).toBeUndefined();
});
it('should be able to find a directive module', () => {
it('should be able to find the NgModule of a component', () => {
const fileName = '/app/app.component.ts';
mockHost.override(fileName, `
import {Component} from '@angular/core';
@ -165,7 +165,24 @@ describe('hover', () => {
expect(quickInfo).toBeTruthy();
const {textSpan, displayParts} = quickInfo !;
expect(textSpan).toEqual(marker);
expect(toText(displayParts)).toBe('(directive) AppModule.AppComponent: class');
expect(toText(displayParts)).toBe('(component) AppModule.AppComponent: class');
});
it('should be able to find the NgModule of a directive', () => {
const fileName = '/app/parsing-cases.ts';
mockHost.override(fileName, `
import {Directive} from '@angular/core';
@Directive({
selector: '[string-model]',
})
export class «StringModel» {}`);
const marker = mockHost.getReferenceMarkerFor(fileName, 'StringModel');
const quickInfo = ngLS.getHoverAt(fileName, marker.start);
expect(quickInfo).toBeTruthy();
const {textSpan, displayParts} = quickInfo !;
expect(textSpan).toEqual(marker);
expect(toText(displayParts)).toBe('(directive) AppModule.StringModel: class');
});
});