cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(renderer): remove unecessary setElementStyles method

Browse Source 
There is no need to expose this additional method inside of the Renderer
API. The functionality can be restored by looping and calling
`setElementStyle` instead.

Note that this change is changing code that was was introduced after
the last release therefore this fix is not a breaking change.

Closes #9000
Closes #9009
This commit is contained in:
Matias Niemelä
2016-06-03 14:59:42 -07:00
parent a6ad61d83e
commit e504d4eb05
12 changed files with 22 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
modules/@angular/compiler/src/animation/animation_compiler.ts
View File

@ -243,12 +243,16 @@ class _AnimationBuilder implements AnimationAstVisitor {
_ANIMATION_END_STATE_STYLES_VAR.set(EMPTY_MAP).toStmt()
]));
var RENDER_STYLES_FN = o.importExpr(Identifiers.renderStyles);
// before we start any animation we want to clear out the starting
// styles from the element's style property (since they were placed
// there at the end of the last animation
statements.push(
_ANIMATION_FACTORY_RENDERER_VAR.callMethod('setElementStyles', [
RENDER_STYLES_FN.callFn([
_ANIMATION_FACTORY_ELEMENT_VAR,
_ANIMATION_FACTORY_RENDERER_VAR,
o.importExpr(Identifiers.clearStyles).callFn([_ANIMATION_START_STATE_STYLES_VAR])
]).toStmt());
@ -269,8 +273,9 @@ class _AnimationBuilder implements AnimationAstVisitor {
statements.push(
_ANIMATION_PLAYER_VAR.callMethod('onDone', [
o.fn([], [
_ANIMATION_FACTORY_RENDERER_VAR.callMethod('setElementStyles', [
RENDER_STYLES_FN.callFn([
_ANIMATION_FACTORY_ELEMENT_VAR,
_ANIMATION_FACTORY_RENDERER_VAR,
o.importExpr(Identifiers.balanceAnimationStyles).callFn([
_ANIMATION_START_STATE_STYLES_VAR,
_ANIMATION_END_STATE_STYLES_VAR